[Extensions] Use CallModuleMethodSafe() in ScriptContext

[Extensions] Use CallModuleMethodSafe() in ScriptContext

In ScriptContext::OnResponseReceived(), instead of immediately executing
JS, request execution. This means we don't receive a result from the
execution. According to comments,

// In debug, the js will validate the callback parameters and return a
// string if a validation error has occured.

This appears to have been true at some point [1], but some time in the
last seven years, has been updated to no longer be the case. As such,
just remove any reference to the result value.

[1] https://chromium.googlesource.com/chromium/src/+/5c21a2eeaa92326a6a771e27c70b11b1ea52441a/chrome/renderer/resources/extension_process_bindings.js#114

BUG=629431
Review-Url: https://codereview.chromium.org/2932913004
Cr-Commit-Position: refs/heads/master@{#478780}
Committed: https://chromium.googlesource.com/chromium/src/+/3043b941f5715ac0ec7d94f2f14d5d9ac9d32b1c

[Devlin, 2017-06-10 02:04:16]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-10 02:04:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-10 02:51:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-10 02:51:47]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-06-12 17:44:32]

Description was changed from

==========
remove from response

BUG=
==========

to

==========
[Extensions] Use CallModuleMethodSafe() in ScriptContext

In ScriptContext::OnResponseReceived(), instead of immediately executing
JS, request execution. This means we don't receive a result from the
execution. According to comments,

// In debug, the js will validate the callback parameters and return a
// string if a validation error has occured.

This appears to have been true at some point [1], but some time in the
last seven years, has been updated to no longer be the case. As such,
just remove any reference to the result value.

[1]
https://chromium.googlesource.com/chromium/src/+/5c21a2eeaa92326a6a771e27c70b...

BUG=629431
==========

[Devlin, 2017-06-12 17:45:02]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Devlin, 2017-06-12 17:45:04]

lazyboy@, mind taking a look?

[lazyboy, 2017-06-12 18:27:18]

lgtm

[Devlin, 2017-06-12 20:39:52]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2017-06-12 20:40:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 21:52:53]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497299992398070, "parent_rev":
"1eb7c8cc54c9648277d10d113ed8a1b0cd1e9a01", "commit_rev":
"3043b941f5715ac0ec7d94f2f14d5d9ac9d32b1c"}

[commit-bot: I haz the power, 2017-06-12 21:53:08]

Description was changed from

==========
[Extensions] Use CallModuleMethodSafe() in ScriptContext

In ScriptContext::OnResponseReceived(), instead of immediately executing
JS, request execution. This means we don't receive a result from the
execution. According to comments,

// In debug, the js will validate the callback parameters and return a
// string if a validation error has occured.

This appears to have been true at some point [1], but some time in the
last seven years, has been updated to no longer be the case. As such,
just remove any reference to the result value.

[1]
https://chromium.googlesource.com/chromium/src/+/5c21a2eeaa92326a6a771e27c70b...

BUG=629431
==========

to

==========
[Extensions] Use CallModuleMethodSafe() in ScriptContext

In ScriptContext::OnResponseReceived(), instead of immediately executing
JS, request execution. This means we don't receive a result from the
execution. According to comments,

// In debug, the js will validate the callback parameters and return a
// string if a validation error has occured.

This appears to have been true at some point [1], but some time in the
last seven years, has been updated to no longer be the case. As such,
just remove any reference to the result value.

[1]
https://chromium.googlesource.com/chromium/src/+/5c21a2eeaa92326a6a771e27c70b...

BUG=629431

Review-Url: https://codereview.chromium.org/2932913004
Cr-Commit-Position: refs/heads/master@{#478780}
Committed:
https://chromium.googlesource.com/chromium/src/+/3043b941f5715ac0ec7d94f2f14d...
==========

[commit-bot: I haz the power, 2017-06-12 21:53:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3043b941f5715ac0ec7d94f2f14d...