Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: extensions/renderer/script_context.cc

Issue 2932913004: [Extensions] Use CallModuleMethodSafe() in ScriptContext (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/script_context.cc
diff --git a/extensions/renderer/script_context.cc b/extensions/renderer/script_context.cc
index 3dc2454a7115e5be0566d0fe736efd22f3304b68..efab66a06402cf1d880f2157295db562d47db982 100644
--- a/extensions/renderer/script_context.cc
+++ b/extensions/renderer/script_context.cc
@@ -379,13 +379,8 @@ void ScriptContext::OnResponseReceived(const std::string& name,
v8::Local<v8::Context>::New(isolate(), v8_context_)),
v8::String::NewFromUtf8(isolate(), error.c_str())};
- v8::Local<v8::Value> retval = module_system()->CallModuleMethod(
- "sendRequest", "handleResponse", arraysize(argv), argv);
-
- // In debug, the js will validate the callback parameters and return a
- // string if a validation error has occured.
- DCHECK(retval.IsEmpty() || retval->IsUndefined())
- << *v8::String::Utf8Value(retval);
+ module_system()->CallModuleMethodSafe("sendRequest", "handleResponse",
+ arraysize(argv), argv);
}
bool ScriptContext::HasAPIPermission(APIPermission::ID permission) const {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698