DevTools: reveal and highlight dom nodes when searching in elements panel.

DevTools: reveal and highlight dom nodes when searching in elements panel.

Review-Url: https://codereview.chromium.org/2932543002
Cr-Commit-Position: refs/heads/master@{#477849}
Committed: https://chromium.googlesource.com/chromium/src/+/41b846b395943c66d8c9d1c7db6b7642684f68af

[pfeldman, 2017-06-07 21:04:43]

pfeldman@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2017-06-07 21:22:29]

lgtm

https://codereview.chromium.org/2932543002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
(right):

https://codereview.chromium.org/2932543002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js:901:
var object = await effectiveNode.resolveToObject('');
Emphasize with comments/empty lines?

https://codereview.chromium.org/2932543002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js (right):

https://codereview.chromium.org/2932543002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js:908: async
scrollIntoView() {
scrollIntoViewAndHighlight()?

https://codereview.chromium.org/2932543002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js:909: var node =
this.enclosingElementOrSelf();
var element =

[pfeldman, 2017-06-07 21:27:08]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2017-06-07 21:27:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 21:29:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 21:29:55]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pfeldman, 2017-06-07 21:45:36]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2017-06-07 21:45:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 21:48:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 21:48:36]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pfeldman, 2017-06-07 23:32:19]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-06-07 23:32:21]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2932543002/#ps20001
(title: "rebaseline")

[commit-bot: I haz the power, 2017-06-07 23:33:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 01:23:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496878339316930,
"parent_rev": "c76be53f9975e1b55b42bb97863dc58047a3f48a", "commit_rev":
"41b846b395943c66d8c9d1c7db6b7642684f68af"}

[commit-bot: I haz the power, 2017-06-08 01:23:46]

Description was changed from

==========
DevTools: reveal and highlight dom nodes when searching in elements panel.
==========

to

==========
DevTools: reveal and highlight dom nodes when searching in elements panel.

Review-Url: https://codereview.chromium.org/2932543002
Cr-Commit-Position: refs/heads/master@{#477849}
Committed:
https://chromium.googlesource.com/chromium/src/+/41b846b395943c66d8c9d1c7db6b...
==========

[commit-bot: I haz the power, 2017-06-08 01:23:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/41b846b395943c66d8c9d1c7db6b...