third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js - Issue 2932543002: DevTools: reveal and highlight dom nodes when searching in elements panel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js

Issue 2932543002: DevTools: reveal and highlight dom nodes when searching in elements panel. (Closed)

Patch Set: rebaseline Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js ('k') | third_party/WebKit/Source/devtools/front_end/elements/PropertiesWidget.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js b/third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js

index 9a15951131590d6d29c9ae2bd2d8881887a27997..07326f92e0288a7aa6531784c39d1fd95b516f48 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js

@@ -100,11 +100,11 @@ Elements.EventListenersWidget = class extends UI.ThrottledWidget {

this._lastRequestedNode = node;

var selectedNodeOnly = !this._showForAncestorsSetting.get();

var promises = [];

- promises.push(node.resolveToObjectPromise(Elements.EventListenersWidget._objectGroupName));

+ promises.push(node.resolveToObject(Elements.EventListenersWidget._objectGroupName));

if (!selectedNodeOnly) {

var currentNode = node.parentNode;

while (currentNode) {

- promises.push(currentNode.resolveToObjectPromise(Elements.EventListenersWidget._objectGroupName));

+ promises.push(currentNode.resolveToObject(Elements.EventListenersWidget._objectGroupName));

currentNode = currentNode.parentNode;

}

promises.push(this._windowObjectInNodeContext(node));