Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2570)

Unified Diff: chrome/browser/ui/views/extensions/chooser_dialog_view.h

Issue 2932523003: Fix Harmony popover buttons being flush with their content. (Closed)
Patch Set: too much padding for bubbles Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/chooser_dialog_view.h
diff --git a/chrome/browser/ui/views/extensions/chooser_dialog_view.h b/chrome/browser/ui/views/extensions/chooser_dialog_view.h
index 231dd9fada692bd6e4ec8a110f547f1ec16e8967..dcb4f6e411f165f8c1d9490158345ab66bc334ba 100644
--- a/chrome/browser/ui/views/extensions/chooser_dialog_view.h
+++ b/chrome/browser/ui/views/extensions/chooser_dialog_view.h
@@ -32,9 +32,6 @@ class ChooserDialogView : public views::DialogDelegateView,
base::string16 GetDialogButtonLabel(ui::DialogButton button) const override;
bool IsDialogButtonEnabled(ui::DialogButton button) const override;
views::View* CreateFootnoteView() override;
- views::ClientView* CreateClientView(views::Widget* widget) override;
Bret 2017/06/07 22:52:18 Removing these changes the layout very slightly pr
Peter Kasting 2017/06/10 01:51:11 Mostly because the net button spacing went from "u
Bret 2017/06/11 00:14:09 Oops, I went to double-check this and it turns out
- views::NonClientFrameView* CreateNonClientFrameView(
- views::Widget* widget) override;
bool Accept() override;
bool Cancel() override;
bool Close() override;

Powered by Google App Engine
This is Rietveld 408576698