Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

Issue 2932523003: Fix Harmony popover buttons being flush with their content. (Closed)
Patch Set: too much padding for bubbles Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc » ('j') | chrome/browser/ui/views/extensions/chooser_dialog_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
index 6c0ece303ba1d69315cf66d1bb8e43178e0c3a14..ed2397dc7b4086120059a0b10c1a6602f8a012c8 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
@@ -337,9 +337,11 @@ void BookmarkBubbleView::Init() {
l10n_util::GetStringUTF16(IDS_BOOKMARK_AX_BUBBLE_FOLDER_LABEL));
layout->AddView(parent_combobox_);
- layout->AddPaddingRow(
- kFixed,
- provider->GetInsetsMetric(views::INSETS_DIALOG_CONTENTS).bottom());
+ if (provider->UseExtraDialogPadding()) {
Bret 2017/06/07 22:52:18 This is redundant post-Harmony with the new paddin
+ layout->AddPaddingRow(
+ kFixed,
+ provider->GetInsetsMetric(views::INSETS_DIALOG_CONTENTS).bottom());
+ }
AddChildView(bookmark_contents_view_);
}
« no previous file with comments | « no previous file | chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc » ('j') | chrome/browser/ui/views/extensions/chooser_dialog_view.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698