Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: chrome/browser/ui/views/extensions/chooser_dialog_view.cc

Issue 2932523003: Fix Harmony popover buttons being flush with their content. (Closed)
Patch Set: too much padding for bubbles Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/chooser_dialog_view.cc
diff --git a/chrome/browser/ui/views/extensions/chooser_dialog_view.cc b/chrome/browser/ui/views/extensions/chooser_dialog_view.cc
index e20b62f8d325a5710ead51527254a428ecf7770e..84ec5d2992fbe5537bf0a6321ed797b11e5d7ef6 100644
--- a/chrome/browser/ui/views/extensions/chooser_dialog_view.cc
+++ b/chrome/browser/ui/views/extensions/chooser_dialog_view.cc
@@ -73,26 +73,6 @@ views::View* ChooserDialogView::CreateFootnoteView() {
return device_chooser_content_view_->footnote_link();
}
-views::ClientView* ChooserDialogView::CreateClientView(views::Widget* widget) {
- views::DialogClientView* client =
- new views::DialogClientView(widget, GetContentsView());
- ChromeLayoutProvider* provider = ChromeLayoutProvider::Get();
- client->SetButtonRowInsets(gfx::Insets(
- provider->GetDistanceMetric(DISTANCE_UNRELATED_CONTROL_VERTICAL), 0, 0,
- 0));
- return client;
-}
-
-views::NonClientFrameView* ChooserDialogView::CreateNonClientFrameView(
- views::Widget* widget) {
- // ChooserDialogView always has a parent, so ShouldUseCustomFrame() should
- // always be true.
- DCHECK(ShouldUseCustomFrame());
- return views::DialogDelegate::CreateDialogFrameView(
- widget, ChromeLayoutProvider::Get()->GetInsetsMetric(
- views::INSETS_BUBBLE_CONTENTS));
-}
-
bool ChooserDialogView::Accept() {
device_chooser_content_view_->Accept();
return true;

Powered by Google App Engine
This is Rietveld 408576698