Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Issue 2932473005: config_service: implement admin group (Closed)

Created:
3 years, 6 months ago by nodir
Modified:
3 years, 6 months ago
Reviewers:
Sergey Berezin, hinoka
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

config_service: implement admin group Add "admin_group" to the acl config so that we can define a limited group that has admin privileges on luci-config, not other services. Also aggressively cache acl.cfg because it ~never changes R=hinoka@chromium.org BUG=730832 Review-Url: https://codereview.chromium.org/2932473005 Committed: https://github.com/luci/luci-py/commit/d3a810515f73c543eab2c1eb9db38a65f9d712e1

Patch Set 1 #

Patch Set 2 : self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -35 lines) Patch
M appengine/components/components/config/proto/service_config.proto View 1 chunk +2 lines, -0 lines 0 comments Download
M appengine/components/components/config/proto/service_config_pb2.py View 13 chunks +29 lines, -22 lines 0 comments Download
M appengine/config_service/acl.py View 1 5 chunks +12 lines, -6 lines 0 comments Download
M appengine/config_service/acl_test.py View 2 chunks +1 line, -2 lines 0 comments Download
M appengine/config_service/admin.py View 2 chunks +3 lines, -1 line 0 comments Download
M appengine/config_service/api.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/config_service/api_test.py View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
nodir
PTAL
3 years, 6 months ago (2017-06-08 18:16:21 UTC) #1
Sergey Berezin
LGTM, thanks!
3 years, 6 months ago (2017-06-08 18:19:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2932473005/20001
3 years, 6 months ago (2017-06-08 18:24:53 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 18:27:09 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/d3a810515f73c543eab2c1eb9db38a65f9d712e1

Powered by Google App Engine
This is Rietveld 408576698