Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2850)

Unified Diff: appengine/config_service/acl_test.py

Issue 2932473005: config_service: implement admin group (Closed)
Patch Set: self review Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/config_service/acl.py ('k') | appengine/config_service/admin.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/config_service/acl_test.py
diff --git a/appengine/config_service/acl_test.py b/appengine/config_service/acl_test.py
index d73c311c3e52242af45e1b45fd34b19886925c7f..e7b38bac07c92eca5d14fba6276c83cb7275c7f8 100755
--- a/appengine/config_service/acl_test.py
+++ b/appengine/config_service/acl_test.py
@@ -33,7 +33,6 @@ class AclTestCase(test_case.TestCase):
super(AclTestCase, self).setUp()
self.mock(auth, 'get_current_identity', mock.Mock())
auth.get_current_identity.return_value = auth.Anonymous
- self.mock(auth, 'is_admin', lambda *_: False)
self.mock(auth, 'is_group_member', mock.Mock(return_value=False))
self.mock(
services, 'get_services_async', mock.Mock(return_value=future([])))
@@ -45,7 +44,7 @@ class AclTestCase(test_case.TestCase):
self.mock(storage, 'get_self_config_async', lambda *_: future(acl_cfg))
def test_admin_can_read_all(self):
- self.mock(auth, 'is_admin', mock.Mock(return_value=True))
+ self.mock(acl, 'is_admin', mock.Mock(return_value=True))
self.assertTrue(can_read_config_set('services/swarming'))
self.assertTrue(can_read_config_set('projects/chromium'))
self.assertTrue(has_project_access('chromium'))
« no previous file with comments | « appengine/config_service/acl.py ('k') | appengine/config_service/admin.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698