Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2932333002: [ObjC ARC] Converts ios/chrome/browser/passwords:passwords_internal to ARC. (Closed)

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, vabr+watchlistpasswordmanager_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, gcasto+watchlist_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/passwords:passwords_internal to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2932333002 Cr-Commit-Position: refs/heads/master@{#478659} Committed: https://chromium.googlesource.com/chromium/src/+/51f2d43236d35f2bfe6b3e5bbe45ffccf42ac39d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -52 lines) Patch
M ios/chrome/browser/passwords/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/passwords/password_generation_prompt_view.mm View 13 chunks +36 lines, -38 lines 0 comments Download
M ios/chrome/browser/passwords/password_generation_prompt_view_controller.mm View 3 chunks +13 lines, -10 lines 0 comments Download
M ios/chrome/browser/passwords/passwords_ui_delegate_impl.mm View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
marq (ping after 24h)
3 years, 6 months ago (2017-06-12 14:42:14 UTC) #4
vabr (Chromium)
Thanks a lot, glad to see development in passwords being easier! LGTM. I spot-checked that ...
3 years, 6 months ago (2017-06-12 15:51:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2932333002/1
3 years, 6 months ago (2017-06-12 16:26:18 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 16:37:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/51f2d43236d35f2bfe6b3e5bbe45...

Powered by Google App Engine
This is Rietveld 408576698