Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: ios/chrome/browser/passwords/password_generation_prompt_view_controller.mm

Issue 2932333002: [ObjC ARC] Converts ios/chrome/browser/passwords:passwords_internal to ARC. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/passwords/password_generation_prompt_view_controller.mm
diff --git a/ios/chrome/browser/passwords/password_generation_prompt_view_controller.mm b/ios/chrome/browser/passwords/password_generation_prompt_view_controller.mm
index 73fb13c9e436f5b15f55c25fcf2469913edeceac..454e1f95d4bdcdfee2661ae53ac96ce40016d180 100644
--- a/ios/chrome/browser/passwords/password_generation_prompt_view_controller.mm
+++ b/ios/chrome/browser/passwords/password_generation_prompt_view_controller.mm
@@ -6,13 +6,15 @@
#import <UIKit/UIKit.h>
-#include "base/ios/weak_nsobject.h"
-#include "base/mac/scoped_nsobject.h"
#import "ios/chrome/browser/passwords/password_generation_prompt_view.h"
#import "ios/chrome/browser/ui/rtl_geometry.h"
#import "ios/chrome/browser/ui/uikit_ui_util.h"
#import "ios/third_party/material_components_ios/src/components/Dialogs/src/MaterialDialogs.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
namespace {
// Material Design Component constraints.
const CGFloat kMDCPadding = 24;
@@ -25,9 +27,10 @@ const CGFloat kPrefHeight = 500;
} // namespace
@interface PasswordGenerationPromptViewController () {
- base::scoped_nsobject<NSString> _password;
- base::WeakNSObject<UIViewController> _viewController;
- base::WeakNSObject<PasswordGenerationPromptDialog> _contentView;
+ NSString* _password;
+ __weak UIViewController* _viewController;
+ __weak PasswordGenerationPromptDialog* _contentView;
+ MDCDialogTransitionController* _dialogTransitionController;
}
// Returns the maximum size of the dialog.
@@ -47,12 +50,12 @@ const CGFloat kPrefHeight = 500;
viewController:(UIViewController*)viewController {
self = [super initWithNibName:nil bundle:nil];
if (self) {
- _password.reset([password copy]);
- _viewController.reset(viewController);
- _contentView.reset(contentView);
+ _password = [password copy];
+ _viewController = viewController;
+ _contentView = contentView;
+ _dialogTransitionController = [[MDCDialogTransitionController alloc] init];
self.modalPresentationStyle = UIModalPresentationCustom;
- self.transitioningDelegate =
- [[[MDCDialogTransitionController alloc] init] autorelease];
+ self.transitioningDelegate = _dialogTransitionController;
}
return self;
}

Powered by Google App Engine
This is Rietveld 408576698