[ObjC ARC] Converts ios/chrome/test:test_support to ARC.

[ObjC ARC] Converts ios/chrome/test:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2932273003
Cr-Commit-Position: refs/heads/master@{#479392}
Committed: https://chromium.googlesource.com/chromium/src/+/e97b8fd261ffb6ccbe1679c87b45b0f9b8407a9b

[marq (ping after 24h), 2017-06-12 12:11:11]

The CQ bit was checked by marq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 12:11:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 12:21:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 12:21:23]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[marq (ping after 24h), 2017-06-12 18:03:45]

Cleanup.

[marq (ping after 24h), 2017-06-12 18:05:26]

The CQ bit was checked by marq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 18:06:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marq (ping after 24h), 2017-06-12 20:19:02]

marq@chromium.org changed reviewers:
+ rohitrao@chromium.org, stkhapugin@chromium.org

[commit-bot: I haz the power, 2017-06-12 21:18:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 21:18:14]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[marq (ping after 24h), 2017-06-13 10:04:24]

I think the BlockCleanupTest itself needs to be non-ARC; I'll have a patch
shortly that takes care of this.

[marq (ping after 24h), 2017-06-13 11:31:23]

Block cleanup no non-ARC.

[marq (ping after 24h), 2017-06-13 11:34:15]

This is ready for review now.

[marq (ping after 24h), 2017-06-13 11:34:24]

The CQ bit was checked by marq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 11:34:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2017-06-13 12:22:54]

lgtm

https://codereview.chromium.org/2932273003/diff/40001/ios/chrome/test/BUILD.gn
File ios/chrome/test/BUILD.gn (left):

https://codereview.chromium.org/2932273003/diff/40001/ios/chrome/test/BUILD.g...
ios/chrome/test/BUILD.gn:32: "scoped_key_window.h",
Please mark ivars as explicit __strong. Memory management in that file seems to
be non-trivial in general.

[commit-bot: I haz the power, 2017-06-13 12:54:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 12:54:42]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2017-06-14 12:30:05]

lgtm

https://codereview.chromium.org/2932273003/diff/40001/ios/chrome/test/BUILD.gn
File ios/chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2932273003/diff/40001/ios/chrome/test/BUILD.g...
ios/chrome/test/BUILD.gn:64: # The files in this target depend on non-ARC
memeory management.
Typo: memory.

https://codereview.chromium.org/2932273003/diff/40001/ios/chrome/test/BUILD.g...
ios/chrome/test/BUILD.gn:64: # The files in this target depend on non-ARC
memeory management.
I wonder if we should add a disable_arc target, so that this can be explicit and
enforced, rather than communicated via comment.

[marq (ping after 24h), 2017-06-14 13:30:32]

Review feedback.

[marq (ping after 24h), 2017-06-14 13:30:32]

The CQ bit was checked by marq@chromium.org

[marq (ping after 24h), 2017-06-14 13:30:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
stkhapugin@chromium.org, rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2932273003/#ps60001
(title: "Review feedback.")

[commit-bot: I haz the power, 2017-06-14 13:30:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marq (ping after 24h), 2017-06-14 13:31:23]

Thanks for the review!

https://codereview.chromium.org/2932273003/diff/40001/ios/chrome/test/BUILD.gn
File ios/chrome/test/BUILD.gn (left):

https://codereview.chromium.org/2932273003/diff/40001/ios/chrome/test/BUILD.g...
ios/chrome/test/BUILD.gn:32: "scoped_key_window.h",
On 2017/06/13 12:22:54, stkhapugin wrote:
> Please mark ivars as explicit __strong. Memory management in that file seems
to
> be non-trivial in general. 

Done.

https://codereview.chromium.org/2932273003/diff/40001/ios/chrome/test/BUILD.gn
File ios/chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2932273003/diff/40001/ios/chrome/test/BUILD.g...
ios/chrome/test/BUILD.gn:64: # The files in this target depend on non-ARC
memeory management.
On 2017/06/14 12:30:05, rohitrao (ping after 24h) wrote:
> Typo: memory.

Done.

https://codereview.chromium.org/2932273003/diff/40001/ios/chrome/test/BUILD.g...
ios/chrome/test/BUILD.gn:64: # The files in this target depend on non-ARC
memeory management.
On 2017/06/14 12:30:05, rohitrao (ping after 24h) wrote:
> I wonder if we should add a disable_arc target, so that this can be explicit
and
> enforced, rather than communicated via comment.

Good idea, created a bug for that.

[commit-bot: I haz the power, 2017-06-14 15:24:45]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497447032926350,
"parent_rev": "7b8e21342731eb18ac94c095fa969ce71957128b", "commit_rev":
"e97b8fd261ffb6ccbe1679c87b45b0f9b8407a9b"}

[commit-bot: I haz the power, 2017-06-14 15:24:56]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/test:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/test:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2932273003
Cr-Commit-Position: refs/heads/master@{#479392}
Committed:
https://chromium.googlesource.com/chromium/src/+/e97b8fd261ffb6ccbe1679c87b45...
==========

[commit-bot: I haz the power, 2017-06-14 15:24:58]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e97b8fd261ffb6ccbe1679c87b45...