[ObjC ARC] Converts ios/chrome/test:test_support to ARC.

ios/chrome/test/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//ios/build/config.gni")
 import("//ios/public/provider/chrome/browser/build_config.gni")
 import("//testing/test.gni")
 
 # All tests needs to be listed in that target to be built as part of
 # "gn_all" target (i.e. by the bots).
 group("all_tests") {
   testonly = true
   deps = [
     ":ios_chrome_perftests",
     ":ios_chrome_unittests",
   ]
 }
 
 source_set("test_support") {
+  configs += [ "//build/config/compiler:enable_arc" ]
   testonly = true
   sources = [
-    "block_cleanup_test.h",
-    "block_cleanup_test.mm",
     "ios_chrome_scoped_testing_chrome_browser_provider.h",
     "ios_chrome_scoped_testing_chrome_browser_provider.mm",
     "ios_chrome_scoped_testing_chrome_browser_state_manager.cc",
     "ios_chrome_scoped_testing_chrome_browser_state_manager.h",
     "ios_chrome_scoped_testing_local_state.cc",
     "ios_chrome_scoped_testing_local_state.h",
     "ios_chrome_unit_test_suite.h",
     "ios_chrome_unit_test_suite.mm",
     "scoped_key_window.h",

[stkhapugin, 2017/06/13 12:22:54]

Please mark ivars as explicit __strong. Memory management in that file seems to
be non-trivial in general. 

[marq (ping after 24h), 2017/06/14 13:31:23]

Done.

     "testing_application_context.h",
     "testing_application_context.mm",
   ]
 
+  public_deps = [
+    ":block_cleanup_test",
+  ]
+
   deps = [
     "//base",
     "//base/test:test_support",
     "//components/content_settings/core/common",
     "//components/network_time",
     "//components/prefs",
     "//components/prefs:test_support",
     "//ios/chrome/browser",
     "//ios/chrome/browser/browser_state",
     "//ios/chrome/browser/browser_state:browser_state_impl",
     "//ios/chrome/browser/prefs:browser_prefs",
     "//ios/public/provider/chrome/browser",
     "//ios/public/provider/chrome/browser:test_support",
     "//ios/web",
     "//ios/web/public/test",
     "//net",
     "//testing/gmock",
     "//testing/gtest",
     "//ui/base",
     "//url",
   ]
 }
 
+source_set("block_cleanup_test") {
+  # The files in this target depend on non-ARC memeory management.

[rohitrao (ping after 24h), 2017/06/14 12:30:05]

I wonder if we should add a disable_arc target, so that this can be explicit and
enforced, rather than communicated via comment.

[rohitrao (ping after 24h), 2017/06/14 12:30:05]

Typo: memory.

[marq (ping after 24h), 2017/06/14 13:31:23]

Good idea, created a bug for that.

[marq (ping after 24h), 2017/06/14 13:31:23]

Done.

+  testonly = true
+  sources = [
+    "block_cleanup_test.h",
+    "block_cleanup_test.mm",
+  ]
+
+  deps = [
+    "//base",
+    "//testing/gtest",
+  ]
+}
+
 source_set("run_all_unittests") {
   testonly = true
   sources = [
     "run_all_unittests.cc",
   ]
   deps = [
     ":test_support",
     "//base",
     "//base/test:test_support",
   ]
@@ skipping 125 matching lines @@
     "//ios/chrome/test/base:unit_tests",
     "//ios/shared/chrome/browser/ui/broadcaster:unit_tests",
     "//ios/shared/chrome/browser/ui/browser_list:unit_tests",
     "//ios/shared/chrome/browser/ui/commands:unit_tests",
     "//ios/shared/chrome/browser/ui/coordinators:unit_tests",
     "//ios/testing:http_server_bundle_data",
   ]
 
   assert_no_deps = ios_assert_no_deps
 }