Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: chrome/browser/chooser_controller/mock_chooser_controller.cc

Issue 2932243002: Refactor ChooserDialogView to use borders instead of content margins. (Closed)
Patch Set: GetTitle not virtual Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chooser_controller/mock_chooser_controller.cc
diff --git a/chrome/browser/chooser_controller/mock_chooser_controller.cc b/chrome/browser/chooser_controller/mock_chooser_controller.cc
index 9763d8c759ca2d8ef0f670336dae363d3a23faa8..c4632e470e5f4ad3519a4165a88de2830a28b133 100644
--- a/chrome/browser/chooser_controller/mock_chooser_controller.cc
+++ b/chrome/browser/chooser_controller/mock_chooser_controller.cc
@@ -14,7 +14,9 @@
MockChooserController::MockChooserController()
: ChooserController(nullptr,
IDS_USB_DEVICE_CHOOSER_PROMPT_ORIGIN,
Jeffrey Yasskin 2017/06/15 22:06:30 Note that this superclass constructor call does se
Bret 2017/06/15 22:50:14 Not if the owner pointer is null. I figured settin
- IDS_USB_DEVICE_CHOOSER_PROMPT_EXTENSION_NAME) {}
+ IDS_USB_DEVICE_CHOOSER_PROMPT_EXTENSION_NAME) {
+ set_title(base::ASCIIToUTF16("Mock Chooser Dialog"));
+}
MockChooserController::~MockChooserController() {}

Powered by Google App Engine
This is Rietveld 408576698