Refactor ChooserDialogView to use borders instead of content margins.

chrome/browser/chooser_controller/mock_chooser_controller.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chooser_controller/mock_chooser_controller.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
 MockChooserController::MockChooserController()
     : ChooserController(nullptr,
                         IDS_USB_DEVICE_CHOOSER_PROMPT_ORIGIN,

[Jeffrey Yasskin, 2017/06/15 22:06:30]

Note that this superclass constructor call does set the title, just to a
maybe-nonobvious value. You might not need this change at all.

[Bret, 2017/06/15 22:50:14]

Not if the owner pointer is null. I figured setting the title directly was
better than drumming up a mock RenderFrameHost just for that.

-                        IDS_USB_DEVICE_CHOOSER_PROMPT_EXTENSION_NAME) {}
+                        IDS_USB_DEVICE_CHOOSER_PROMPT_EXTENSION_NAME) {
+  set_title(base::ASCIIToUTF16("Mock Chooser Dialog"));
+}
 
 MockChooserController::~MockChooserController() {}
 
 bool MockChooserController::ShouldShowIconBeforeText() const {
   return true;
 }
 
 base::string16 MockChooserController::GetNoOptionsText() const {
   return l10n_util::GetStringUTF16(IDS_DEVICE_CHOOSER_NO_DEVICES_FOUND_PROMPT);
 }
@@ skipping 119 matching lines @@
 const int MockChooserController::kSignalStrengthLevel1Bar = 1;
 const int MockChooserController::kSignalStrengthLevel2Bar = 2;
 const int MockChooserController::kSignalStrengthLevel3Bar = 3;
 const int MockChooserController::kSignalStrengthLevel4Bar = 4;
 const int MockChooserController::kImageColorUnselected = 0;
 const int MockChooserController::kImageColorSelected = 1;
 
 void MockChooserController::ClearAllOptions() {
   options_.clear();
 }