Refactor ChooserDialogView to use borders instead of content margins.

chrome/browser/chooser_controller/chooser_controller.h

Index: chrome/browser/chooser_controller/chooser_controller.h
diff --git a/chrome/browser/chooser_controller/chooser_controller.h b/chrome/browser/chooser_controller/chooser_controller.h
index 33658c6ee8e405e567eb169f751bb35c030b7af3..ac765bc3e8c180b20dd8df218f6d6252595e2bd7 100644
--- a/chrome/browser/chooser_controller/chooser_controller.h
+++ b/chrome/browser/chooser_controller/chooser_controller.h
@@ -130,6 +130,9 @@ class ChooserController {
   void set_view(View* view) { view_ = view; }
   View* view() const { return view_; }
 
+ protected:
+  void set_title(base::string16 title) { title_ = title; }

[Jeffrey Yasskin, 2017/06/15 22:06:30]

Either const base::string16& or std::move(title). I never remember which one our
style guide prefers.

[juncai, 2017/06/15 22:14:57]

drive-by comment: Since this function is only for testing, maybe add
"_for_testing" explicitly in its function name to be: "set_title_for_testing()".

[Peter Kasting, 2017/06/15 22:26:14]

Since I just looked this up an hour ago: we prefer passing strings by const ref
to pass-by-value-and-move.

[Bret, 2017/06/15 22:50:14]

All done.

+
  private:
   base::string16 title_;
   View* view_ = nullptr;