Print detailed info in check_gn_headers.py

Print detailed info in check_gn_headers.py

When --verbose is given, print more detailed info to help debugging.
The dependency of offending header files and the obj files they affect
should help determine which files to fix. The number of affected
object files can be a proxy of seriousness.

If the whitelist is not given, the extra detail would be very long.

BUG=661774
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng

Review-Url: https://codereview.chromium.org/2932153002
Cr-Commit-Position: refs/heads/master@{#478956}
Committed: https://chromium.googlesource.com/chromium/src/+/8cc3123c31e0538f0f10be6329683d9c698fbfed

[wychen, 2017-06-10 06:18:39]

wychen@chromium.org changed reviewers:
+ dbeam@chromium.org

[wychen, 2017-06-10 06:18:39]

PTAL

[Dan Beam, 2017-06-12 17:46:48]

lgtm but i'm not super duper familiar with this code

[wychen, 2017-06-12 23:08:33]

wychen@chromium.org changed reviewers:
+ dpranke@chromium.org

[wychen, 2017-06-12 23:08:34]

dpranke@chromium.org: PTAL

[Dirk Pranke, 2017-06-12 23:34:11]

Assuming I understand this correctly, this'll modify the output so that you'll
print which object files depend on a given header, right?

Isn't that going to be *a lot* of data? Maybe just print the first N objects or
something?

[Dirk Pranke, 2017-06-12 23:34:53]

Also, please update the CL description to be more detailed and specific about
what you're printing.

[wychen, 2017-06-12 23:45:11]

Description was changed from

==========
Print detailed info in check_gn_headers.py

Print more detailed info to help debugging which file to fix.

BUG=661774
==========

to

==========
Print detailed info in check_gn_headers.py

When --verbose is given, print more detailed info to help debugging.
The dependency of offending header files and the obj files they affect
should help determine which files to fix. The number of affected
object files can be a proxy of seriousness.

If the whitelist is not given, the extra detail would be very long.

BUG=661774
==========

[wychen, 2017-06-12 23:50:49]

On 2017/06/12 23:34:11, Dirk Pranke wrote:
> Assuming I understand this correctly, this'll modify the output so that you'll
> print which object files depend on a given header, right?
> 
> Isn't that going to be *a lot* of data? Maybe just print the first N objects
or
> something?

Most of the headers only affect <10 files.
With the whitelist, the total amount of data should be more or less manageable.
It's the case on the bots, and when investigating the CQ failure, local run
should specify whitelist file as well.

Updated the CL description.

[Dirk Pranke, 2017-06-12 23:56:57]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2017-06-12 23:56:58]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2932153002/#ps80001
(title: "hide behind --verbose")

[Dirk Pranke, 2017-06-12 23:57:00]

The CQ bit was unchecked by dpranke@chromium.org

[Dirk Pranke, 2017-06-12 23:57:14]

ok, thanks!

lgtm.

[wychen, 2017-06-12 23:58:00]

The CQ bit was checked by wychen@chromium.org

[commit-bot: I haz the power, 2017-06-12 23:58:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 00:13:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 00:13:08]

Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[wychen, 2017-06-13 07:57:16]

The CQ bit was checked by wychen@chromium.org

[commit-bot: I haz the power, 2017-06-13 07:57:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 08:01:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 08:01:10]

Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[wychen, 2017-06-13 08:51:28]

Description was changed from

==========
Print detailed info in check_gn_headers.py

When --verbose is given, print more detailed info to help debugging.
The dependency of offending header files and the obj files they affect
should help determine which files to fix. The number of affected
object files can be a proxy of seriousness.

If the whitelist is not given, the extra detail would be very long.

BUG=661774
==========

to

==========
Print detailed info in check_gn_headers.py

When --verbose is given, print more detailed info to help debugging.
The dependency of offending header files and the obj files they affect
should help determine which files to fix. The number of affected
object files can be a proxy of seriousness.

If the whitelist is not given, the extra detail would be very long.

BUG=661774
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng
==========

[wychen, 2017-06-13 08:53:15]

The CQ bit was checked by wychen@chromium.org

[wychen, 2017-06-13 08:53:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2932153002/#ps120001
(title: "lint")

[commit-bot: I haz the power, 2017-06-13 08:53:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 10:21:26]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1497343995787030,
"parent_rev": "9aa0274f471d0bc845edae1d1c2a7db67770a82f", "commit_rev":
"8cc3123c31e0538f0f10be6329683d9c698fbfed"}

[commit-bot: I haz the power, 2017-06-13 10:21:36]

Description was changed from

==========
Print detailed info in check_gn_headers.py

When --verbose is given, print more detailed info to help debugging.
The dependency of offending header files and the obj files they affect
should help determine which files to fix. The number of affected
object files can be a proxy of seriousness.

If the whitelist is not given, the extra detail would be very long.

BUG=661774
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng
==========

to

==========
Print detailed info in check_gn_headers.py

When --verbose is given, print more detailed info to help debugging.
The dependency of offending header files and the obj files they affect
should help determine which files to fix. The number of affected
object files can be a proxy of seriousness.

If the whitelist is not given, the extra detail would be very long.

BUG=661774
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng

Review-Url: https://codereview.chromium.org/2932153002
Cr-Commit-Position: refs/heads/master@{#478956}
Committed:
https://chromium.googlesource.com/chromium/src/+/8cc3123c31e0538f0f10be632968...
==========

[commit-bot: I haz the power, 2017-06-13 10:21:38]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/8cc3123c31e0538f0f10be632968...