Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3456)

Unified Diff: build/check_gn_headers_unittest.py

Issue 2932153002: Print detailed info in check_gn_headers.py (Closed)
Patch Set: lint Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/check_gn_headers.py ('k') | testing/scripts/check_gn_headers.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/check_gn_headers_unittest.py
diff --git a/build/check_gn_headers_unittest.py b/build/check_gn_headers_unittest.py
index 20b41f4b957eb9a83f1850d79d7c0495637585aa..20c3b138979036d2d96b6601bd3ef48c099e710f 100755
--- a/build/check_gn_headers_unittest.py
+++ b/build/check_gn_headers_unittest.py
@@ -5,7 +5,6 @@
import logging
import json
-import os
import unittest
import check_gn_headers
@@ -65,13 +64,13 @@ a/b/c
class CheckGnHeadersTest(unittest.TestCase):
def testNinja(self):
headers = check_gn_headers.ParseNinjaDepsOutput(
- ninja_input.split('\n'), 'out/Release')
- expected = set([
- 'dir/path/b.h',
- 'c.hh',
- 'dir3/path/b.h',
- 'c3.hh',
- ])
+ ninja_input.split('\n'), 'out/Release', False)
+ expected = {
+ 'dir/path/b.h': ['obj/a.o'],
+ 'c.hh': ['obj/a.o'],
+ 'dir3/path/b.h': ['obj/c.o'],
+ 'c3.hh': ['obj/c.o'],
+ }
self.assertEquals(headers, expected)
def testGn(self):
« no previous file with comments | « build/check_gn_headers.py ('k') | testing/scripts/check_gn_headers.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698