Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2932063003: Augment the browser startup timeout when using the PGO profiler. (Closed)

Created:
3 years, 6 months ago by Sébastien Marchand
Modified:
3 years, 6 months ago
Reviewers:
nednguyen, sullivan
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Augment the browser startup timeout when using the PGO profiler. I know that this profiler is deprecated and should be replaced by something else but I'm seeing a lot of these timeouts on the PGO bots and this is causing a lot of release issues, this will temporarily fix these issues while I work on replacing this profiler. BUG=chromium:729562 Review-Url: https://codereview.chromium.org/2932063003 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/1ffc3ed0526747eded946b2970a50046603b9272

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M telemetry/telemetry/internal/platform/profiler/win_pgo_profiler.py View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Sébastien Marchand
PTAL
3 years, 6 months ago (2017-06-09 14:45:25 UTC) #2
sullivan
deferring this to Ned.
3 years, 6 months ago (2017-06-09 14:49:43 UTC) #4
nednguyen
lgtm
3 years, 6 months ago (2017-06-09 14:56:12 UTC) #5
Sébastien Marchand
Thanks, committing. Should I roll deps once this has been submitted or will it be ...
3 years, 6 months ago (2017-06-09 15:00:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2932063003/1
3 years, 6 months ago (2017-06-09 15:01:05 UTC) #8
nednguyen
On 2017/06/09 15:00:50, Sébastien Marchand wrote: > Thanks, committing. > > Should I roll deps ...
3 years, 6 months ago (2017-06-09 15:04:30 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 15:26:21 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698