Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: telemetry/telemetry/internal/platform/profiler/win_pgo_profiler.py

Issue 2932063003: Augment the browser startup timeout when using the PGO profiler. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/platform/profiler/win_pgo_profiler.py
diff --git a/telemetry/telemetry/internal/platform/profiler/win_pgo_profiler.py b/telemetry/telemetry/internal/platform/profiler/win_pgo_profiler.py
index d11e43b67ddfe8c9840af94a76c57e468ab1725b..fbd80460f0322a365f2e168c1b810a29d6904a52 100644
--- a/telemetry/telemetry/internal/platform/profiler/win_pgo_profiler.py
+++ b/telemetry/telemetry/internal/platform/profiler/win_pgo_profiler.py
@@ -15,6 +15,9 @@ _PGOSWEEP_EXECUTABLE = 'pgosweep.exe'
class WinPGOProfiler(profiler.Profiler):
"""A profiler that run the Visual Studio PGO utility 'pgosweep.exe' before
terminating a browser or a renderer process.
+
+ TODO(sebmarchand): Stop relying on Telemetry to do this, move this logic to
+ Chrome.
"""
def __init__(self, browser_backend, platform_backend, output_path, state):
@@ -89,6 +92,9 @@ class WinPGOProfiler(profiler.Profiler):
# The sandbox need to be disabled if we want to be able to gather the
# profile data.
options.AppendExtraBrowserArgs('--no-sandbox')
+ # Augment the startup timeout as a PGO instrumented build takes more time to
+ # start than a regular build.
+ options.browser_options.browser_startup_timeout *= 4
def CollectProfile(self):
"""Collect the profile data for the current processes."""
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698