Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2932053004: Stubbed out linking on Fuchsia (Closed)

Created:
3 years, 6 months ago by scottmg
Modified:
3 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Stubbed out linking on Fuchsia Follows https://codereview.chromium.org/2931143002/. Sufficient to link d8 with target_os="fuchsia" in Chrome. No implementations of platform functions yet, just stubs. BUG=chromium:731217 Review-Url: https://codereview.chromium.org/2932053004 Cr-Commit-Position: refs/heads/master@{#45832} Committed: https://chromium.googlesource.com/v8/v8/+/dc3de67047032343d89193fc87267e64ea3d325e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
A src/base/debug/stack_trace_fuchsia.cc View 1 chunk +38 lines, -0 lines 0 comments Download
A src/base/platform/platform-fuchsia.cc View 1 chunk +85 lines, -0 lines 0 comments Download
M src/v8.gyp View 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (5 generated)
scottmg
3 years, 6 months ago (2017-06-09 19:39:24 UTC) #3
Benedikt Meurer
lgtm
3 years, 6 months ago (2017-06-10 16:36:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2932053004/1
3 years, 6 months ago (2017-06-11 14:12:00 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-11 14:34:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/dc3de67047032343d89193fc87267e64ea3...

Powered by Google App Engine
This is Rietveld 408576698