Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2931143002: Basic compilation on Fuchsia (Closed)

Created:
3 years, 6 months ago by scottmg
Modified:
3 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Basic compilation on Fuchsia Sufficient to compile //v8 in Chrome with target_os="fuchsia". Doesn't link yet, due to missing implementations (primarily VirtualMemory, as well as a few utility functions). BUG=chromium:731217 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng Review-Url: https://codereview.chromium.org/2931143002 Cr-Commit-Position: refs/heads/master@{#45831} Committed: https://chromium.googlesource.com/v8/v8/+/c72a612667a104ac5ce989ae210b53c8f87add23

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M include/v8config.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/base/platform/platform-posix.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/libsampler/sampler.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (15 generated)
scottmg
3 years, 6 months ago (2017-06-09 18:54:12 UTC) #4
Benedikt Meurer
lgtm
3 years, 6 months ago (2017-06-10 16:37:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2931143002/1
3 years, 6 months ago (2017-06-11 05:45:43 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-06-11 06:31:43 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c72a612667a104ac5ce989ae210b53c8f87...

Powered by Google App Engine
This is Rietveld 408576698