Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Issue 2932043003: fix #29789, avoid unneccessary dcalls and checks in dart:_runtime (Closed)

Created:
3 years, 6 months ago by Jennifer Messerly
Modified:
3 years, 6 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix #29789, avoid unneccessary dcalls and checks in dart:_runtime R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/e79fbd167b24a515cde63ff37db5e410f053ad11

Patch Set 1 #

Total comments: 1

Patch Set 2 : tweak #

Patch Set 3 : merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View 1 2 Binary file 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/rtti.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart View 1 2 5 chunks +14 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
https://codereview.chromium.org/2932043003 https://codereview.chromium.org/2932043003/diff/1/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart (right): https://codereview.chromium.org/2932043003/diff/1/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart#newcode437 pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart:437: return _functionType == null ? _functionType = _closure() ...
3 years, 6 months ago (2017-06-10 00:43:09 UTC) #2
vsm
lgtm
3 years, 6 months ago (2017-06-12 19:41:18 UTC) #3
Jennifer Messerly
3 years, 6 months ago (2017-06-12 22:44:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:20001) manually as
e79fbd167b24a515cde63ff37db5e410f053ad11 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698