pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/rtti.dart - Issue 2932043003: fix #29789, avoid unneccessary dcalls and checks in dart:_runtime

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/rtti.dart

Issue 2932043003: fix #29789, avoid unneccessary dcalls and checks in dart:_runtime (Closed)

Patch Set: merged Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/rtti.dart

diff --git a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/rtti.dart b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/rtti.dart

index a19c5af599db97cde1ac904535a6ca6e2541551a..23e1a2fd87769019481386a133ed9ea8beba8e05 100644

--- a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/rtti.dart

+++ b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/rtti.dart

@@ -110,7 +110,7 @@ _checkPrimitiveType(obj) {

getFunctionType(obj) {

// TODO(vsm): Encode this properly on the function for Dart-generated code.

- var args = JS('', 'Array(#.length).fill(#)', obj, dynamic);

+ var args = JS('List', 'Array(#.length).fill(#)', obj, dynamic);

return fnType(bottom, args, JS('', 'void 0'));

}