Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1076)

Issue 2931803002: [kernel] Cleanup kernel code after streaming (part 1). (Closed)

Created:
3 years, 6 months ago by jensj
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[kernel] Cleanup kernel code. This deletes some visitors and the can_stream field in the Ast. This should be seen as a cleanup for now-unused code now that we're streaming. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/0462a5a99126986de976ee3fc71444c85f806558

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1285 lines) Patch
M runtime/vm/kernel.h View 96 chunks +1 line, -418 lines 0 comments Download
M runtime/vm/kernel.cc View 47 chunks +0 lines, -703 lines 0 comments Download
M runtime/vm/kernel_binary.cc View 60 chunks +0 lines, -164 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (3 generated)
jensj
3 years, 6 months ago (2017-06-08 10:47:59 UTC) #3
Kevin Millikin (Google)
Sticks the value! LGTM.
3 years, 6 months ago (2017-06-19 13:02:15 UTC) #4
jensj
3 years, 6 months ago (2017-06-20 07:50:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0462a5a99126986de976ee3fc71444c85f806558 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698