[kernel] Streaming refactorings.

[kernel] Streaming refactorings.

Refactorings.
Mostly about only reading FunctionNode one place by introducing a
helper class that will read and skip what it is told.
For 'nested' things inside the function node (e.g. the body),
the caller for the helper still needs to handle it if it shouldn't
just be skipped.
'Non-nested' things (e.g. integers) are saved and can be fetched
by the caller.

R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/2a7a410c937440a54ea38d21360e3c6f330bc9b1

[jensj, 2017-06-01 11:15:17]

jensj@google.com changed reviewers:
+ kmillikin@google.com

[jensj, 2017-06-01 11:15:17]

What do you think?
If you're okay with this sort of refactoring, I will do the same thing to for
instance VariableDeclaration.

[jensj, 2017-06-02 11:17:15]

(I added more helper classes).

[jensj, 2017-06-14 09:29:32]

mind the rebase.

[Kevin Millikin (Google), 2017-06-19 13:00:27]

LGTM.

I have some ideas about ways we might make this simpler from an API standpoint,
but lets wait until the binary format changes we're planning are completed.

[jensj, 2017-06-20 07:22:57]

Description was changed from

==========
[kernel] Streaming refactorings.

Refactorings.
Mostly about only reading FunctionNode one place by introducing a
helper class that will read and skip what it is told.
For 'nested' things inside the function node (e.g. the body),
the caller for the helper still needs to handle it if it shouldn't
just be skipped.
'Non-nested' things (e.g. integers) are saved and can be fetched
by the caller.
==========

to

==========
[kernel] Streaming refactorings.

Refactorings.
Mostly about only reading FunctionNode one place by introducing a
helper class that will read and skip what it is told.
For 'nested' things inside the function node (e.g. the body),
the caller for the helper still needs to handle it if it shouldn't
just be skipped.
'Non-nested' things (e.g. integers) are saved and can be fetched
by the caller.

R=kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2a7a410c937440a54ea38d21360e3c6f330bc9b1
==========

[jensj, 2017-06-20 07:22:59]

Committed patchset #5 (id:80001) manually as
2a7a410c937440a54ea38d21360e3c6f330bc9b1 (presubmit successful).