[kernel] Stream kernel_reader

[kernel] Stream kernel_reader

Mostly stream kernel_reader, i.e. the code that sets up the libraries,
classes, methods etc.

Mostly because it still takes a "Program" ast node, and looks at the
"Library" ast nodes to get their kernel offset in the binary.
Currently the scripts (containing breakable points etc) are also created
from the ast nodes.

The rest is now streamed.
This also means that more ast visitors could be deleted.

R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/80860e7fb752dd8fedbe6dd13336b30f7ff35764

[jensj, 2017-06-08 11:19:22]

jensj@google.com changed reviewers:
+ kmillikin@google.com

[jensj, 2017-06-08 11:19:23]

Notice that this changes the binary format slightly.

[Kevin Millikin (Google), 2017-06-21 09:10:41]

LGTM.

https://codereview.chromium.org/2931813002/diff/20001/runtime/vm/kernel_reade...
File runtime/vm/kernel_reader.cc (right):

https://codereview.chromium.org/2931813002/diff/20001/runtime/vm/kernel_reade...
runtime/vm/kernel_reader.cc:256: intptr_t num_annotations = builder_.ReadUInt();
 // read list length.
I prefer to call this annotation_count, and dependency_count below.

[jensj, 2017-06-21 12:59:03]

Description was changed from

==========
[kernel] Stream kernel_reader

Mostly stream kernel_reader, i.e. the code that sets up the libraries,
classes, methods etc.

Mostly because it still takes a "Program" ast node, and looks at the
"Library" ast nodes to get their kernel offset in the binary.
Currently the scripts (containing breakable points etc) are also created
from the ast nodes.

The rest is now streamed.
This also means that more ast visitors could be deleted.
==========

to

==========
[kernel] Stream kernel_reader

Mostly stream kernel_reader, i.e. the code that sets up the libraries,
classes, methods etc.

Mostly because it still takes a "Program" ast node, and looks at the
"Library" ast nodes to get their kernel offset in the binary.
Currently the scripts (containing breakable points etc) are also created
from the ast nodes.

The rest is now streamed.
This also means that more ast visitors could be deleted.

R=kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/80860e7fb752dd8fedbe6dd13336b30f7ff35764
==========

[jensj, 2017-06-21 12:59:04]

Committed patchset #3 (id:40001) manually as
80860e7fb752dd8fedbe6dd13336b30f7ff35764 (presubmit successful).