Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 2931693002: Explicitly set names for remaining stories in v8 benchmarks (Closed)

Created:
3 years, 6 months ago by ashleymarie1
Modified:
3 years, 6 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly set names for remaining stories in v8 benchmarks BUG=chromium:720002 Review-Url: https://codereview.chromium.org/2931693002 Cr-Commit-Position: refs/heads/master@{#477906} Committed: https://chromium.googlesource.com/chromium/src/+/01434413de13b34170d0cd803c1d606412bda5a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M tools/perf/page_sets/infinite_scroll_cases.py View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/perf/page_sets/v8_top_25.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
ashleymarie1
3 years, 6 months ago (2017-06-07 20:06:29 UTC) #2
nednguyen
lgtm
3 years, 6 months ago (2017-06-07 20:23:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2931693002/1
3 years, 6 months ago (2017-06-07 20:32:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/429017) win_clang on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 6 months ago (2017-06-07 20:55:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2931693002/1
3 years, 6 months ago (2017-06-08 04:51:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/01434413de13b34170d0cd803c1d606412bda5a1
3 years, 6 months ago (2017-06-08 05:55:56 UTC) #12
Camillo Bruni
3 years, 6 months ago (2017-06-09 13:34:30 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698