tools/perf/page_sets/v8_top_25.py - Issue 2931693002: Explicitly set names for remaining stories in v8 benchmarks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/v8_top_25.py

Issue 2931693002: Explicitly set names for remaining stories in v8 benchmarks (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/v8_top_25.py

diff --git a/tools/perf/page_sets/v8_top_25.py b/tools/perf/page_sets/v8_top_25.py

index ed94ba38c404ea6e788828d44f759b39be641ead..f7f98c930078dbccb9d9a5a9332307379125ee69 100644

--- a/tools/perf/page_sets/v8_top_25.py

+++ b/tools/perf/page_sets/v8_top_25.py

@@ -67,7 +67,8 @@ class V8Top25StorySet(story.StorySet):

def __init__(self):

super(V8Top25StorySet, self).__init__(

archive_data_file='data/v8_top_25.json',

- cloud_storage_bucket=story.INTERNAL_BUCKET)

+ cloud_storage_bucket=story.INTERNAL_BUCKET,

+ verify_names=True)

for url in urls_list:

- self.AddStory(V8Top25(url, self))

+ self.AddStory(V8Top25(url, self, url))

« no previous file with comments | « tools/perf/page_sets/infinite_scroll_cases.py ('k') | no next file » | no next file with comments »