[LayoutNG] Implement 'text-align-last'

[LayoutNG] Implement 'text-align-last'

This patch takes 'text-align-last' into account to determine the used
value of 'text-align', though not all used values of text-align is not
supported yet.

In doing so, this patch adds NGLineInfo, similar to LineInfo, that
communicates the properties of a line box to
NGInlineLayoutAlgorithm::CreateLine(). IsFirstLine() for '::first-line'
pseudo elements is moved to this class. Some more fields will be added
in future, such as trialing spaces.

LayoutBlockFlow::TextAlignmentForLine() is moved to ComputedStyle to
share the code with LayoutObject, though the function still remains
since LayoutRuby overrides the function.

Tests in fast/css3-text/css3-text-align-last do not pass yet since
single test file contains all values.

BUG=636993
Review-Url: https://codereview.chromium.org/2931563002
Cr-Commit-Position: refs/heads/master@{#478860}
Committed: https://chromium.googlesource.com/chromium/src/+/b8eb36b221b05003be9f36ffae3d2e3a5a77651e

[kojii, 2017-06-07 06:22:51]

Description was changed from

==========
nglast

BUG=
==========

to

==========
nglast

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-06-07 11:31:52]

Patchset #4 (id:60001) has been deleted

[kojii, 2017-06-08 03:39:13]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 03:39:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-06-08 03:39:32]

Patchset #5 (id:100001) has been deleted

[kojii, 2017-06-08 03:48:29]

Description was changed from

==========
nglast

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Implement 'text-align-last'

This patch takes 'text-align-last' into account to determine the used
value of 'text-align', though not all used values of text-align is not
supported yet.

In doing so, this patch adds NGLineInfo, similar to LineInfo, that
communicates the properties of a line box to
NGInlineLayoutAlgorithm::CreateLine(). IsFirstLine() for '::first-line'
pseudo elements is moved to this class.

LayoutBlockFlow::TextAlignmentForLine() is moved to ComputedStyle to
share the code with LayoutObject, though the function still remains
since LayoutRuby overrides the function.

Tests in fast/css3-text/css3-text-align-last do not pass yet since
single test file contains all values.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-06-08 03:48:38]

kojii@chromium.org changed reviewers:
+ eae@chromium.org

[kojii, 2017-06-08 03:48:39]

PTAL.

[kojii, 2017-06-08 05:19:42]

Description was changed from

==========
[LayoutNG] Implement 'text-align-last'

This patch takes 'text-align-last' into account to determine the used
value of 'text-align', though not all used values of text-align is not
supported yet.

In doing so, this patch adds NGLineInfo, similar to LineInfo, that
communicates the properties of a line box to
NGInlineLayoutAlgorithm::CreateLine(). IsFirstLine() for '::first-line'
pseudo elements is moved to this class.

LayoutBlockFlow::TextAlignmentForLine() is moved to ComputedStyle to
share the code with LayoutObject, though the function still remains
since LayoutRuby overrides the function.

Tests in fast/css3-text/css3-text-align-last do not pass yet since
single test file contains all values.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Implement 'text-align-last'

This patch takes 'text-align-last' into account to determine the used
value of 'text-align', though not all used values of text-align is not
supported yet.

In doing so, this patch adds NGLineInfo, similar to LineInfo, that
communicates the properties of a line box to
NGInlineLayoutAlgorithm::CreateLine(). IsFirstLine() for '::first-line'
pseudo elements is moved to this class. Some more fields will be added
in future, such as trialing spaces.

LayoutBlockFlow::TextAlignmentForLine() is moved to ComputedStyle to
share the code with LayoutObject, though the function still remains
since LayoutRuby overrides the function.

Tests in fast/css3-text/css3-text-align-last do not pass yet since
single test file contains all values.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[commit-bot: I haz the power, 2017-06-08 05:39:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 05:39:53]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_layout_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))

[eae, 2017-06-12 16:52:07]

This is great, thank you!

LGTM

[kojii, 2017-06-12 19:48:02]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-06-12 19:49:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 20:00:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 20:00:02]

Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[kojii, 2017-06-12 20:27:31]

The CQ bit was checked by kojii@chromium.org

[kojii, 2017-06-12 20:27:32]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2931563002/#ps140001
(title: "Rebase")

[commit-bot: I haz the power, 2017-06-12 20:28:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 22:29:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 22:29:37]

Try jobs failed on following builders:
  linux_layout_tests_layout_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))

[kojii, 2017-06-13 01:44:53]

Description was changed from

==========
[LayoutNG] Implement 'text-align-last'

This patch takes 'text-align-last' into account to determine the used
value of 'text-align', though not all used values of text-align is not
supported yet.

In doing so, this patch adds NGLineInfo, similar to LineInfo, that
communicates the properties of a line box to
NGInlineLayoutAlgorithm::CreateLine(). IsFirstLine() for '::first-line'
pseudo elements is moved to this class. Some more fields will be added
in future, such as trialing spaces.

LayoutBlockFlow::TextAlignmentForLine() is moved to ComputedStyle to
share the code with LayoutObject, though the function still remains
since LayoutRuby overrides the function.

Tests in fast/css3-text/css3-text-align-last do not pass yet since
single test file contains all values.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Implement 'text-align-last'

This patch takes 'text-align-last' into account to determine the used
value of 'text-align', though not all used values of text-align is not
supported yet.

In doing so, this patch adds NGLineInfo, similar to LineInfo, that
communicates the properties of a line box to
NGInlineLayoutAlgorithm::CreateLine(). IsFirstLine() for '::first-line'
pseudo elements is moved to this class. Some more fields will be added
in future, such as trialing spaces.

LayoutBlockFlow::TextAlignmentForLine() is moved to ComputedStyle to
share the code with LayoutObject, though the function still remains
since LayoutRuby overrides the function.

Tests in fast/css3-text/css3-text-align-last do not pass yet since
single test file contains all values.

BUG=636993
==========

[kojii, 2017-06-13 01:44:56]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-06-13 01:45:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 01:51:09]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1497318296650220,
"parent_rev": "0e8121522085f344b83cc86c514e4bfb7f7c5a22", "commit_rev":
"b8eb36b221b05003be9f36ffae3d2e3a5a77651e"}

[commit-bot: I haz the power, 2017-06-13 01:51:22]

Description was changed from

==========
[LayoutNG] Implement 'text-align-last'

This patch takes 'text-align-last' into account to determine the used
value of 'text-align', though not all used values of text-align is not
supported yet.

In doing so, this patch adds NGLineInfo, similar to LineInfo, that
communicates the properties of a line box to
NGInlineLayoutAlgorithm::CreateLine(). IsFirstLine() for '::first-line'
pseudo elements is moved to this class. Some more fields will be added
in future, such as trialing spaces.

LayoutBlockFlow::TextAlignmentForLine() is moved to ComputedStyle to
share the code with LayoutObject, though the function still remains
since LayoutRuby overrides the function.

Tests in fast/css3-text/css3-text-align-last do not pass yet since
single test file contains all values.

BUG=636993
==========

to

==========
[LayoutNG] Implement 'text-align-last'

This patch takes 'text-align-last' into account to determine the used
value of 'text-align', though not all used values of text-align is not
supported yet.

In doing so, this patch adds NGLineInfo, similar to LineInfo, that
communicates the properties of a line box to
NGInlineLayoutAlgorithm::CreateLine(). IsFirstLine() for '::first-line'
pseudo elements is moved to this class. Some more fields will be added
in future, such as trialing spaces.

LayoutBlockFlow::TextAlignmentForLine() is moved to ComputedStyle to
share the code with LayoutObject, though the function still remains
since LayoutRuby overrides the function.

Tests in fast/css3-text/css3-text-align-last do not pass yet since
single test file contains all values.

BUG=636993

Review-Url: https://codereview.chromium.org/2931563002
Cr-Commit-Position: refs/heads/master@{#478860}
Committed:
https://chromium.googlesource.com/chromium/src/+/b8eb36b221b05003be9f36ffae3d...
==========

[commit-bot: I haz the power, 2017-06-13 01:51:25]

Committed patchset #6 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/b8eb36b221b05003be9f36ffae3d...

[atotic, 2017-06-13 05:58:08]

On 2017/06/13 at 01:51:25, commit-bot wrote:
> Committed patchset #6 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/b8eb36b221b05003be9f36ffae3d...

A remainder: we should update TestExpectations.

[kojii, 2017-06-13 06:06:37]

On 2017/06/13 at 05:58:08, atotic wrote:
> A remainder: we should update TestExpectations.

Yeah, I neglected and delegated to my maintenance work as ng-bot is slow, but
the maintenance is in queue...I'm asking if we can add another bot. Thanks for
the reminder.