third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc - Issue 2931563002: [LayoutNG] Implement 'text-align-last'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc

Issue 2931563002: [LayoutNG] Implement 'text-align-last' (Closed)

Patch Set: Rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.cc ('k') | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc b/third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc

index cd39ff4dff3d66a0ea0b526024a2e312d0c1426d..9332247a44dc446d6d37098051ec84a8a25c4cea 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc

@@ -38,13 +38,9 @@ class NGLineBreakerTest : public NGBaseLayoutAlgorithmTest {

NGLineBreaker line_breaker(node, space.Get());

NGInlineLayoutAlgorithm algorithm(node, space.Get());

Vector<NGInlineItemResults> lines;

- while (true) {

- NGInlineItemResults item_results;

- line_breaker.NextLine(&item_results, &algorithm);

- if (item_results.IsEmpty())

- break;

- lines.push_back(item_results);

- }

+ NGLineInfo line_info;

+ while (line_breaker.NextLine(&line_info, &algorithm))

+ lines.push_back(std::move(line_info.Results()));

return lines;

}

};