Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2931503002: [Payments] Improve some accessibility labels in editors (Closed)

Created:
3 years, 6 months ago by Mathieu
Modified:
3 years, 6 months ago
Reviewers:
anthonyvd
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Improve some accessibility labels in editors BUG=729633 TEST=VoiceOver Review-Url: https://codereview.chromium.org/2931503002 Cr-Commit-Position: refs/heads/master@{#478600} Committed: https://chromium.googlesource.com/chromium/src/+/c40f49bfd5d6574449f8fb8bdb774684f5355094

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc View 2 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/payments/editor_view_controller.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Mathieu
PTAL
3 years, 6 months ago (2017-06-06 20:13:18 UTC) #3
Mathieu
Friendly ping
3 years, 6 months ago (2017-06-10 20:04:53 UTC) #8
anthonyvd
lgtm Sorry about the delay, I missed this because we've mostly been using Gerrit.
3 years, 6 months ago (2017-06-12 12:37:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2931503002/1
3 years, 6 months ago (2017-06-12 12:40:45 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 13:30:08 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c40f49bfd5d6574449f8fb8bdb77...

Powered by Google App Engine
This is Rietveld 408576698