Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc

Issue 2931503002: [Payments] Improve some accessibility labels in editors (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/payments/editor_view_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
diff --git a/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc b/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
index 6a2ce102e303e3dc1c0d2a2b8b9f64e4ed6ca599..97fe25f89cf687a5cf3403a6a159b2803bc9517a 100644
--- a/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
+++ b/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
@@ -280,10 +280,11 @@ CreditCardEditorViewController::CreateCustomFieldView(
combobox_layout->StartRow(0, 0);
constexpr int kInputFieldHeight = 28;
- EditorField tmp_month{autofill::CREDIT_CARD_EXP_MONTH, base::string16(),
- EditorField::LengthHint::HINT_SHORT,
- /*required=*/true,
- EditorField::ControlType::COMBOBOX};
+ EditorField tmp_month{
+ autofill::CREDIT_CARD_EXP_MONTH,
+ l10n_util::GetStringUTF16(IDS_AUTOFILL_FIELD_LABEL_EXPIRATION_MONTH),
+ EditorField::LengthHint::HINT_SHORT,
+ /*required=*/true, EditorField::ControlType::COMBOBOX};
std::unique_ptr<ValidatingCombobox> month_combobox =
CreateComboboxForField(tmp_month);
*focusable_field = month_combobox.get();
@@ -291,9 +292,11 @@ CreditCardEditorViewController::CreateCustomFieldView(
views::GridLayout::FILL, views::GridLayout::FILL,
0, kInputFieldHeight);
- EditorField tmp_year{autofill::CREDIT_CARD_EXP_4_DIGIT_YEAR,
- base::string16(), EditorField::LengthHint::HINT_SHORT,
- /*required=*/true, EditorField::ControlType::COMBOBOX};
+ EditorField tmp_year{
+ autofill::CREDIT_CARD_EXP_4_DIGIT_YEAR,
+ l10n_util::GetStringUTF16(IDS_AUTOFILL_FIELD_LABEL_EXPIRATION_YEAR),
+ EditorField::LengthHint::HINT_SHORT,
+ /*required=*/true, EditorField::ControlType::COMBOBOX};
std::unique_ptr<ValidatingCombobox> year_combobox =
CreateComboboxForField(tmp_year);
combobox_layout->AddView(year_combobox.release(), 1, 1,
« no previous file with comments | « no previous file | chrome/browser/ui/views/payments/editor_view_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698