[ActiveSuggestionMarker #2.5] Handle ActiveSuggestionMarkers for accessibility

Handle ActiveSuggestionMarkers for accessibility

I'm adding a new type of DocumentMarker, ActiveSuggestionMarker, in
https://codereview.chromium.org/2923033002. This MarkerType will be used to mark
the region of text that an open spellcheck/suggestion menu pertains to. This
seems potentially useful to expose for accessibility, so I'm doing that in this
CL (I didn't want to add more complexity to the original CL).

BUG=715365
Review-Url: https://codereview.chromium.org/2931473002
Cr-Commit-Position: refs/heads/master@{#477481}
Committed: https://chromium.googlesource.com/chromium/src/+/b1d2f5d73ed7f1656733cc55c4abc8c716b47ee8

[rlanday, 2017-06-06 19:24:32]

rlanday@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[rlanday, 2017-06-06 19:24:36]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 19:25:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-06-06 19:27:41]

https://codereview.chromium.org/2931473002/diff/1/ui/accessibility/ax_enums.idl
File ui/accessibility/ax_enums.idl (right):

https://codereview.chromium.org/2931473002/diff/1/ui/accessibility/ax_enums.i...
ui/accessibility/ax_enums.idl:545: // DocumentMarker::MarkerType::Composition =
8 is ignored for accessibility
Am I updating this file correctly? It's a little weird since we're skipping over
Composition markers. I could re-order the list of MarkerTypes to put Composition
on the bottom again, but it doesn't really seem right that the ordering should
be constrained in this way (e.g. what happens if some other DocumentMarker use
case wants the enum in a different order?).

This seems to get exponentially more difficult to maintain as we add more
MarkerTypes. I'm planning to add at least one more after this.

[dmazzoni, 2017-06-06 19:44:32]

lgtm

https://codereview.chromium.org/2931473002/diff/1/ui/accessibility/ax_enums.idl
File ui/accessibility/ax_enums.idl (right):

https://codereview.chromium.org/2931473002/diff/1/ui/accessibility/ax_enums.i...
ui/accessibility/ax_enums.idl:545: // DocumentMarker::MarkerType::Composition =
8 is ignored for accessibility
On 2017/06/06 19:27:41, rlanday wrote:
> Am I updating this file correctly? It's a little weird since we're skipping
over
> Composition markers. I could re-order the list of MarkerTypes to put
Composition
> on the bottom again, but it doesn't really seem right that the ordering should
> be constrained in this way (e.g. what happens if some other DocumentMarker use
> case wants the enum in a different order?).
> 
> This seems to get exponentially more difficult to maintain as we add more
> MarkerTypes. I'm planning to add at least one more after this.

You're right, this doesn't scale.

Please add a TODO for me and/or nektar@ to fix this.
Thanks for adding the permutations in the meantime.

[rlanday, 2017-06-06 20:05:01]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 20:05:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 22:41:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 22:41:42]

Dry run: This issue passed the CQ dry run.

[rlanday, 2017-06-07 00:17:04]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-06-07 00:17:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2931473002/#ps20001
(title: "Add TODO")

[commit-bot: I haz the power, 2017-06-07 00:17:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 00:21:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496794624915950,
"parent_rev": "9180be89e65e6475a82b662b9ef7e065e9fe88d3", "commit_rev":
"b1d2f5d73ed7f1656733cc55c4abc8c716b47ee8"}

[commit-bot: I haz the power, 2017-06-07 00:21:50]

Description was changed from

==========
Handle ActiveSuggestionMarkers for accessibility

I'm adding a new type of DocumentMarker, ActiveSuggestionMarker, in
https://codereview.chromium.org/2923033002. This MarkerType will be used to mark
the region of text that an open spellcheck/suggestion menu pertains to. This
seems potentially useful to expose for accessibility, so I'm doing that in this
CL (I didn't want to add more complexity to the original CL).

BUG=715365
==========

to

==========
Handle ActiveSuggestionMarkers for accessibility

I'm adding a new type of DocumentMarker, ActiveSuggestionMarker, in
https://codereview.chromium.org/2923033002. This MarkerType will be used to mark
the region of text that an open spellcheck/suggestion menu pertains to. This
seems potentially useful to expose for accessibility, so I'm doing that in this
CL (I didn't want to add more complexity to the original CL).

BUG=715365

Review-Url: https://codereview.chromium.org/2931473002
Cr-Commit-Position: refs/heads/master@{#477481}
Committed:
https://chromium.googlesource.com/chromium/src/+/b1d2f5d73ed7f1656733cc55c4ab...
==========

[commit-bot: I haz the power, 2017-06-07 00:21:52]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b1d2f5d73ed7f1656733cc55c4ab...