[ActiveSuggestionMarker #2.5] Handle ActiveSuggestionMarkers for accessibility

ui/accessibility/ax_enums.idl

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(nektar): Migrate entire file to Mojoq.
 // These should be kept in sync with third_party/WebKit/public/web/WebAXEnums.h
 // until the Chromium and Blink trees are merged.
 [camel_case_enum_to_string=true] namespace ui {
 
   // For new entries to the following four enums, also add to
@@ skipping 523 matching lines @@
   };
 
   enum AXMarkerType {
     // Assignments are ignored by the parser, but are kept here for clarity.
     spelling = 1,
     grammar = 2,
     spelling_grammar = 3,
     text_match = 4,
     spelling_text_match = 5,
     grammar_text_match = 6,
-    spelling_grammar_text_match = 7
+    spelling_grammar_text_match = 7,
+    // DocumentMarker::MarkerType::Composition = 8 is ignored for accessibility

[rlanday, 2017/06/06 19:27:41]

Am I updating this file correctly? It's a little weird since we're skipping over
Composition markers. I could re-order the list of MarkerTypes to put Composition
on the bottom again, but it doesn't really seem right that the ordering should
be constrained in this way (e.g. what happens if some other DocumentMarker use
case wants the enum in a different order?).

This seems to get exponentially more difficult to maintain as we add more
MarkerTypes. I'm planning to add at least one more after this.

[dmazzoni, 2017/06/06 19:44:32]

You're right, this doesn't scale.

Please add a TODO for me and/or nektar@ to fix this.
Thanks for adding the permutations in the meantime.

+    // purposes
+    active_suggestion = 16,
+    spelling_active_suggestion = 17,
+    grammar_active_suggestion = 18,
+    spelling_grammar_active_suggestion = 19,
+    text_match_active_suggestion = 20,
+    spelling_text_match_active_suggestion = 21,
+    grammar_text_match_active_suggestion = 22,
+    spelling_grammar_text_match_active_suggestion = 23
   };
 
   enum AXTextDirection {
     ltr,
     rtl,
     ttb,
     btt
   };
 
   // A Java counterpart will be generated for this enum.
@@ skipping 106 matching lines @@
     // First node is before the second one.
     before,
 
     // Nodes are the same.
     equal,
 
     // First node is after the second one.
     after
   };
 };