Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: extensions/renderer/messaging_bindings.cc

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/messaging_bindings.cc
diff --git a/extensions/renderer/messaging_bindings.cc b/extensions/renderer/messaging_bindings.cc
index d58e43c4d02beebe3a2420b974a353a2247591a9..6d5246c72ba4eeee072caf58888b40fd0d12c32c 100644
--- a/extensions/renderer/messaging_bindings.cc
+++ b/extensions/renderer/messaging_bindings.cc
@@ -107,9 +107,8 @@ void DispatchOnConnectToScriptContext(
if (extension) {
if (!source->tab.empty() && !extension->is_platform_app()) {
- std::unique_ptr<content::V8ValueConverter> converter(
- content::V8ValueConverter::create());
- tab = converter->ToV8Value(&source->tab, script_context->v8_context());
+ tab = content::V8ValueConverter::Create()->ToV8Value(
+ &source->tab, script_context->v8_context());
}
ExternallyConnectableInfo* externally_connectable =

Powered by Google App Engine
This is Rietveld 408576698