extensions/renderer/js_extension_bindings_system.cc - Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/js_extension_bindings_system.cc

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/js_extension_bindings_system.cc

diff --git a/extensions/renderer/js_extension_bindings_system.cc b/extensions/renderer/js_extension_bindings_system.cc

index 45c3500c3cfa701d8bd613095346bbdee7a0289d..e0b297482098f8a0ac65e968ec850ef2d6c747b4 100644

--- a/extensions/renderer/js_extension_bindings_system.cc

+++ b/extensions/renderer/js_extension_bindings_system.cc

@@ -257,8 +257,8 @@ void JsExtensionBindingsSystem::DispatchEventInContext(

arguments.push_back(gin::StringToSymbol(context->isolate(), event_name));

{

- std::unique_ptr<content::V8ValueConverter> converter(

- content::V8ValueConverter::create());

+ std::unique_ptr<content::V8ValueConverter> converter =

+ content::V8ValueConverter::Create();

arguments.push_back(

converter->ToV8Value(event_args, context->v8_context()));

if (filtering_info && !filtering_info->empty()) {