Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: extensions/renderer/runtime_custom_bindings.cc

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/runtime_custom_bindings.cc
diff --git a/extensions/renderer/runtime_custom_bindings.cc b/extensions/renderer/runtime_custom_bindings.cc
index 66ed982fb558d4d96dabdee457734b7dc22969f8..f95c7e952fea37aecc60e72aa9bba38eed36db3d 100644
--- a/extensions/renderer/runtime_custom_bindings.cc
+++ b/extensions/renderer/runtime_custom_bindings.cc
@@ -38,9 +38,7 @@ void RuntimeCustomBindings::GetManifest(
const v8::FunctionCallbackInfo<v8::Value>& args) {
CHECK(context()->extension());
- std::unique_ptr<content::V8ValueConverter> converter(
- content::V8ValueConverter::create());
- args.GetReturnValue().Set(converter->ToV8Value(
+ args.GetReturnValue().Set(content::V8ValueConverter::Create()->ToV8Value(
context()->extension()->manifest()->value(), context()->v8_context()));
}

Powered by Google App Engine
This is Rietveld 408576698