Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2931173002: Revert of Set BOTO_CONFIG correctly in cloud_storage.py (Closed)

Created:
3 years, 6 months ago by lpique
Modified:
3 years, 6 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of Set BOTO_CONFIG correctly in cloud_storage.py (patchset #1 id:1 of https://codereview.chromium.org/2923123006/ ) Reason for revert: It turns out this did not fix the issue on the buildbot. The .boto file might be on the buildbot at this path, but the tests that are failing are running inside a VM, and don't have access to it in the first place. Another approach is needed to fix the linked bug, and we will likely put a .boto file in the home directory that is being set when running gsutil. Original issue's description: > Set BOTO_CONFIG correctly in cloud_storage.py > > When running the telemetry perf tests on a VM host as root, the .boto was not > being found. > > This patch simply sets the BOTO_CONFIG environment variable to point at > the correct location. > > Bug: chromium:712349 > Review-Url: https://codereview.chromium.org/2923123006 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/23ac69b72e05e6d1788c915353bdd75dd596f1e7 TBR=nednguyen@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2931173002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f3c416239e8ac0ce2962714f1b6e70da709198a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M common/py_utils/py_utils/cloud_storage.py View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
lpique
Created Revert of Set BOTO_CONFIG correctly in cloud_storage.py
3 years, 6 months ago (2017-06-09 19:32:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2931173002/1
3 years, 6 months ago (2017-06-09 19:32:50 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-09 19:32:51 UTC) #5
lpique
Looks like I need an LGTM first. PTAL.
3 years, 6 months ago (2017-06-09 19:35:58 UTC) #6
nednguyen
lgtm
3 years, 6 months ago (2017-06-09 19:36:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2931173002/1
3 years, 6 months ago (2017-06-09 19:37:20 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 20:02:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698