Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2923123006: Set BOTO_CONFIG correctly in cloud_storage.py (Closed)

Created:
3 years, 6 months ago by lpique
Modified:
3 years, 6 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Set BOTO_CONFIG correctly in cloud_storage.py When running the telemetry perf tests on a VM host as root, the .boto was not being found. This patch simply sets the BOTO_CONFIG environment variable to point at the correct location. Bug: chromium:712349 Review-Url: https://codereview.chromium.org/2923123006 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/23ac69b72e05e6d1788c915353bdd75dd596f1e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M common/py_utils/py_utils/cloud_storage.py View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
lpique
PTAL.
3 years, 6 months ago (2017-06-06 20:34:39 UTC) #3
nednguyen
lgtm
3 years, 6 months ago (2017-06-06 20:35:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923123006/1
3 years, 6 months ago (2017-06-06 20:39:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Presubmit/builds/7403)
3 years, 6 months ago (2017-06-06 20:41:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923123006/1
3 years, 6 months ago (2017-06-06 21:41:44 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Presubmit/builds/7405)
3 years, 6 months ago (2017-06-06 21:43:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923123006/1
3 years, 6 months ago (2017-06-06 21:46:54 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/23ac69b72e05e6d1788c915353bdd75dd596f1e7
3 years, 6 months ago (2017-06-06 21:48:09 UTC) #19
lpique
3 years, 6 months ago (2017-06-09 19:32:40 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2931173002/ by lpique@chromium.org.

The reason for reverting is: It turns out this did not fix the issue on the
buildbot. The .boto file might be on the buildbot at this path, but the tests
that are failing are running inside a VM, and don't have access to it in the
first place.

Another approach is needed to fix the linked bug, and we will likely put a .boto
file in the home directory that is being set when running gsutil..

Powered by Google App Engine
This is Rietveld 408576698