Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2930983003: [Media Router UI] Fix pseudo sink logic for cast modes. (Closed)

Created:
3 years, 6 months ago by imcheng
Modified:
3 years, 6 months ago
Reviewers:
mark a. foltz
CC:
arv+watch_chromium.org, chromium-reviews, imcheng+watch_chromium.org, mfoltz+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router UI] Fix pseudo sink logic for cast modes. This fixes an issue where "Cast desktop" is shown in the dialog when there are no sinks except for the pseudo sink (which isn't shown). BUG=731350 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2930983003 Cr-Commit-Position: refs/heads/master@{#478158} Committed: https://chromium.googlesource.com/chromium/src/+/dfc69988626f677be76ad509a0dbe47d8a8ecc54

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/webui/media_router/media_router_container_cast_mode_list_tests.js View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
imcheng
PTAL, thanks!
3 years, 6 months ago (2017-06-08 23:52:41 UTC) #3
mark a. foltz
LGTM I checked other uses of castModeList and this seems to be the only place ...
3 years, 6 months ago (2017-06-09 00:09:47 UTC) #4
imcheng
Yep, I hope we can get rid of pseudo sinks some day and replace it ...
3 years, 6 months ago (2017-06-09 00:29:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2930983003/1
3 years, 6 months ago (2017-06-09 00:30:38 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 01:44:44 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dfc69988626f677be76ad509a0db...

Powered by Google App Engine
This is Rietveld 408576698