[Media Router UI] Fix pseudo sink logic for cast modes.

[Media Router UI] Fix pseudo sink logic for cast modes.

This fixes an issue where "Cast desktop" is shown in the dialog when
there are no sinks except for the pseudo sink (which isn't shown).

BUG=731350
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2930983003
Cr-Commit-Position: refs/heads/master@{#478158}
Committed: https://chromium.googlesource.com/chromium/src/+/dfc69988626f677be76ad509a0dbe47d8a8ecc54

[imcheng, 2017-06-08 23:50:19]

Description was changed from

==========
[Media Router UI] Fix pseudo sink logic for cast modes.

This fixes an issue where "Cast desktop" is shown in the dialog when
there are no sinks except for the pseudo sink (which isn't shown).

BUG=731350
==========

to

==========
[Media Router UI] Fix pseudo sink logic for cast modes.

This fixes an issue where "Cast desktop" is shown in the dialog when
there are no sinks except for the pseudo sink (which isn't shown).

BUG=731350
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[imcheng, 2017-06-08 23:52:40]

imcheng@chromium.org changed reviewers:
+ mfoltz@chromium.org

[imcheng, 2017-06-08 23:52:41]

PTAL, thanks!

[mark a. foltz, 2017-06-09 00:09:47]

LGTM

I checked other uses of castModeList and this seems to be the only place that
needs updating.  Regardless, it would be nice to replace the pseudo-sink with a
well defined object representing the search field.  Maybe the Meetings folks can
help out with some refactorings like this :-)

[imcheng, 2017-06-09 00:29:57]

Yep, I hope we can get rid of pseudo sinks some day and replace it with
something more intuitive (at least not a sink :)

[imcheng, 2017-06-09 00:30:06]

The CQ bit was checked by imcheng@chromium.org

[commit-bot: I haz the power, 2017-06-09 00:30:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 01:44:29]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496968206954200, "parent_rev":
"cd0c21dfb32b6235c5c4bed740dac090b4e25bae", "commit_rev":
"dfc69988626f677be76ad509a0dbe47d8a8ecc54"}

[commit-bot: I haz the power, 2017-06-09 01:44:41]

Description was changed from

==========
[Media Router UI] Fix pseudo sink logic for cast modes.

This fixes an issue where "Cast desktop" is shown in the dialog when
there are no sinks except for the pseudo sink (which isn't shown).

BUG=731350
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[Media Router UI] Fix pseudo sink logic for cast modes.

This fixes an issue where "Cast desktop" is shown in the dialog when
there are no sinks except for the pseudo sink (which isn't shown).

BUG=731350
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2930983003
Cr-Commit-Position: refs/heads/master@{#478158}
Committed:
https://chromium.googlesource.com/chromium/src/+/dfc69988626f677be76ad509a0db...
==========

[commit-bot: I haz the power, 2017-06-09 01:44:44]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dfc69988626f677be76ad509a0db...