chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js - Issue 2930983003: [Media Router UI] Fix pseudo sink logic for cast modes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

Issue 2930983003: [Media Router UI] Fix pseudo sink logic for cast modes. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

diff --git a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

index f7c83258a29c0bb157835e5b1fe146137778f584..155bc82031fd8bf9f4699defaae97426f2c577b6 100644

--- a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

+++ b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

@@ -642,7 +642,8 @@ Polymer({

return forcedMode;

var allCastModes = this.allSinks.reduce(function(castModesSoFar, sink) {

- return castModesSoFar | sink.castModes;

+ // Ignore pseudo sinks in the cast mode computation.

+ return castModesSoFar | (sink.isPseudoSink ? 0 : sink.castModes);

}, 0);

// This checks whether |castModes| does not consist of exactly 1 cast mode.

« no previous file with comments | « no previous file | chrome/test/data/webui/media_router/media_router_container_cast_mode_list_tests.js » ('j') | no next file with comments »