Change all "google.com" references in net/cookies to "foo.com" to avoid repeatedly tripping ov…

Change all "google.com" references in net/cookies to "foo.com".

This avoids repeatedly tripping over presubmit check @ https://cs.chromium.org/chromium/src/PRESUBMIT.py?q=PRESUBMIT.py&sq=package:chromium&dr=C&l=1082

BUG=None
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2930893002
Cr-Commit-Position: refs/heads/master@{#478326}
Committed: https://chromium.googlesource.com/chromium/src/+/e4815989660c3ef60e99b55d9b936246714e4719

[Randy Smith (Not in Mondays), 2017-06-08 15:45:59]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 15:46:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Randy Smith (Not in Mondays), 2017-06-08 15:47:28]

I was tempted to title this CL "You Have Failed Me For The Last Time, Presubmit"
:-}.  A straight query replace in the files I found "google.com" in other than
the one place marked below.  PTAL?

https://codereview.chromium.org/2930893002/diff/1/net/cookies/cookie_store_un...
File net/cookies/cookie_store_unittest.h (right):

https://codereview.chromium.org/2930893002/diff/1/net/cookies/cookie_store_un...
net/cookies/cookie_store_unittest.h:713: EXPECT_TRUE(this->SetCookie(cs, url,
"b=2; domain=.wWw.gOOgLE.izzLE"));
Only location that wasn't a straight query replace.

[mmenke, 2017-06-08 15:58:56]

You should have used gstatic.com, since that's not in the list.  :)

So...umm...cookies care about registry controlled domains, and so changing from
a real TLD to a non-real one seems a concerning to me (To the extent that I'd
feel I have to review how cookies deal with registry controlled domains, and how
we deal with unrecognized registry controlled domains).  Could we just switch to
foo.com or something?

[Randy Smith (Not in Mondays), 2017-06-08 16:12:47]

Description was changed from

==========
Change all "google.com" references in net/cookies to "google.izzle" to avoid
repeatedly tripping over presubmit check @
https://cs.chromium.org/chromium/src/PRESUBMIT.py?q=PRESUBMIT.py&sq=package:c...

BUG=None
R=mmenke@chromium.org
==========

to

==========
Change all "google.com" references in net/cookies to "foo.com".

This avoids repeatedly tripping over presubmit check @
https://cs.chromium.org/chromium/src/PRESUBMIT.py?q=PRESUBMIT.py&sq=package:c...

BUG=None
R=mmenke@chromium.org
==========

[Randy Smith (Not in Mondays), 2017-06-08 16:15:32]

On 2017/06/08 15:58:56, mmenke wrote:
> You should have used http://gstatic.com, since that's not in the list.  :)

Good point!  :-}

> So...umm...cookies care about registry controlled domains, and so changing
from
> a real TLD to a non-real one seems a concerning to me (To the extent that I'd
> feel I have to review how cookies deal with registry controlled domains, and
how
> we deal with unrecognized registry controlled domains).  Could we just switch
to
> http://foo.com or something?

foo.com it is!  Though (You're gonna love me for pointing this out.  Or maybe
I'll be the one to suffer.) there were a lot of google.izzles in the file
*before* I did the switch, which I've now switched to foo.com, which means this
CL still represents a shift between real and non-real TLDs.  I'd like to have a
simple pattern for future tests to follow, as opposed to it being semi-random,
which I think means I need to do that switch.  But I fully grant that the CL may
not be worth the effort it would take to review it, in which case I'll just kill
it.  Let me know.

[Randy Smith (Not in Mondays), 2017-06-08 16:15:38]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 16:15:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 17:16:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 17:16:34]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[mmenke, 2017-06-08 17:46:07]

On 2017/06/08 16:15:32, Randy Smith (Not in Mondays) wrote:
> On 2017/06/08 15:58:56, mmenke wrote:
> > You should have used http://gstatic.com, since that's not in the list.  :)
> 
> Good point!  :-}
> 
> > So...umm...cookies care about registry controlled domains, and so changing
> from
> > a real TLD to a non-real one seems a concerning to me (To the extent that
I'd
> > feel I have to review how cookies deal with registry controlled domains, and
> how
> > we deal with unrecognized registry controlled domains).  Could we just
switch
> to
> > http://foo.com or something?
> 
> http://foo.com it is!  Though (You're gonna love me for pointing this out.  Or
maybe
> I'll be the one to suffer.) there were a lot of google.izzles in the file
> *before* I did the switch, which I've now switched to http://foo.com, which
means this
> CL still represents a shift between real and non-real TLDs.  I'd like to have
a
> simple pattern for future tests to follow, as opposed to it being semi-random,
> which I think means I need to do that switch.  But I fully grant that the CL
may
> not be worth the effort it would take to review it, in which case I'll just
kill
> it.  Let me know.

I think this is a reasonable thing to do, unless we want to modify the
presubmit.  LGTM

[Randy Smith (Not in Mondays), 2017-06-08 19:27:19]

On 2017/06/08 17:46:07, mmenke wrote:
> On 2017/06/08 16:15:32, Randy Smith (Not in Mondays) wrote:
> > On 2017/06/08 15:58:56, mmenke wrote:
> > > You should have used http://gstatic.com, since that's not in the list.  :)
> > 
> > Good point!  :-}
> > 
> > > So...umm...cookies care about registry controlled domains, and so changing
> > from
> > > a real TLD to a non-real one seems a concerning to me (To the extent that
> I'd
> > > feel I have to review how cookies deal with registry controlled domains,
and
> > how
> > > we deal with unrecognized registry controlled domains).  Could we just
> switch
> > to
> > > http://foo.com or something?
> > 
> > http://foo.com it is!  Though (You're gonna love me for pointing this out. 
Or
> maybe
> > I'll be the one to suffer.) there were a lot of google.izzles in the file
> > *before* I did the switch, which I've now switched to http://foo.com, which
> means this
> > CL still represents a shift between real and non-real TLDs.  I'd like to
have
> a
> > simple pattern for future tests to follow, as opposed to it being
semi-random,
> > which I think means I need to do that switch.  But I fully grant that the CL
> may
> > not be worth the effort it would take to review it, in which case I'll just
> kill
> > it.  Let me know.
> 
> I think this is a reasonable thing to do, unless we want to modify the
> presubmit.  LGTM

Just FYI, I'm caught in a "No good deed goes unpunished": The change from
google.izzle -> foo.com did indeed cause a test breakage, but (IIUC) it was a
breakage of a test that shouldn't have been passing anyway.  I'm dealing with
that in https://codereview.chromium.org/2929923002/ and will merge that one into
this CL.  I'll want one more stamp from you anyway, as I realized that there
were variables *named* www_google_com_ that contained www.foo.com, which seemed
broken.  So there's large diff coming.

[Randy Smith (Not in Mondays), 2017-06-08 19:32:14]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[mmenke, 2017-06-08 19:32:50]

On 2017/06/08 19:27:19, Randy Smith (Not in Mondays) wrote:
> On 2017/06/08 17:46:07, mmenke wrote:
> > On 2017/06/08 16:15:32, Randy Smith (Not in Mondays) wrote:
> > > On 2017/06/08 15:58:56, mmenke wrote:
> > > > You should have used http://gstatic.com, since that's not in the list. 
:)
> > > 
> > > Good point!  :-}
> > > 
> > > > So...umm...cookies care about registry controlled domains, and so
changing
> > > from
> > > > a real TLD to a non-real one seems a concerning to me (To the extent
that
> > I'd
> > > > feel I have to review how cookies deal with registry controlled domains,
> and
> > > how
> > > > we deal with unrecognized registry controlled domains).  Could we just
> > switch
> > > to
> > > > http://foo.com or something?
> > > 
> > > http://foo.com it is!  Though (You're gonna love me for pointing this out.

> Or
> > maybe
> > > I'll be the one to suffer.) there were a lot of google.izzles in the file
> > > *before* I did the switch, which I've now switched to http://foo.com,
which
> > means this
> > > CL still represents a shift between real and non-real TLDs.  I'd like to
> have
> > a
> > > simple pattern for future tests to follow, as opposed to it being
> semi-random,
> > > which I think means I need to do that switch.  But I fully grant that the
CL
> > may
> > > not be worth the effort it would take to review it, in which case I'll
just
> > kill
> > > it.  Let me know.
> > 
> > I think this is a reasonable thing to do, unless we want to modify the
> > presubmit.  LGTM
> 
> Just FYI, I'm caught in a "No good deed goes unpunished": The change from
> google.izzle -> http://foo.com did indeed cause a test breakage, but (IIUC) it
was a
> breakage of a test that shouldn't have been passing anyway.  I'm dealing with
> that in https://codereview.chromium.org/2929923002/ and will merge that one
into
> this CL.  I'll want one more stamp from you anyway, as I realized that there
> were variables *named* www_google_com_ that contained http://www.foo.com,
which seemed
> broken.  So there's large diff coming.

That's what you get when you have a variable named "http_www_google_", and an
ambiguous final domain.  :(

[commit-bot: I haz the power, 2017-06-08 19:33:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Randy Smith (Not in Mondays), 2017-06-08 19:34:20]

On 2017/06/08 19:32:50, mmenke wrote:
> On 2017/06/08 19:27:19, Randy Smith (Not in Mondays) wrote:
> > On 2017/06/08 17:46:07, mmenke wrote:
> > > On 2017/06/08 16:15:32, Randy Smith (Not in Mondays) wrote:
> > > > On 2017/06/08 15:58:56, mmenke wrote:
> > > > > You should have used http://gstatic.com, since that's not in the list.

> :)
> > > > 
> > > > Good point!  :-}
> > > > 
> > > > > So...umm...cookies care about registry controlled domains, and so
> changing
> > > > from
> > > > > a real TLD to a non-real one seems a concerning to me (To the extent
> that
> > > I'd
> > > > > feel I have to review how cookies deal with registry controlled
domains,
> > and
> > > > how
> > > > > we deal with unrecognized registry controlled domains).  Could we just
> > > switch
> > > > to
> > > > > http://foo.com or something?
> > > > 
> > > > http://foo.com it is!  Though (You're gonna love me for pointing this
out.
> 
> > Or
> > > maybe
> > > > I'll be the one to suffer.) there were a lot of google.izzles in the
file
> > > > *before* I did the switch, which I've now switched to http://foo.com,
> which
> > > means this
> > > > CL still represents a shift between real and non-real TLDs.  I'd like to
> > have
> > > a
> > > > simple pattern for future tests to follow, as opposed to it being
> > semi-random,
> > > > which I think means I need to do that switch.  But I fully grant that
the
> CL
> > > may
> > > > not be worth the effort it would take to review it, in which case I'll
> just
> > > kill
> > > > it.  Let me know.
> > > 
> > > I think this is a reasonable thing to do, unless we want to modify the
> > > presubmit.  LGTM
> > 
> > Just FYI, I'm caught in a "No good deed goes unpunished": The change from
> > google.izzle -> http://foo.com did indeed cause a test breakage, but (IIUC)
it
> was a
> > breakage of a test that shouldn't have been passing anyway.  I'm dealing
with
> > that in https://codereview.chromium.org/2929923002/ and will merge that one
> into
> > this CL.  I'll want one more stamp from you anyway, as I realized that there
> > were variables *named* www_google_com_ that contained http://www.foo.com,
> which seemed
> > broken.  So there's large diff coming.
> 
> That's what you get when you have a variable named "http_www_google_", and an
> ambiguous final domain.  :(

Alternatively: That's what you get when you try to clean up a tar baby :-} :-J.

[commit-bot: I haz the power, 2017-06-08 19:42:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 19:42:35]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Randy Smith (Not in Mondays), 2017-06-08 19:52:22]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 19:52:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 21:22:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 21:22:27]

Dry run: This issue passed the CQ dry run.

[Randy Smith (Not in Mondays), 2017-06-08 21:40:04]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 21:40:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 00:18:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 00:18:25]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Randy Smith (Not in Mondays), 2017-06-09 13:40:16]

Matt: This is ready for a second review.  PTAL?

[mmenke, 2017-06-09 15:06:38]

On 2017/06/09 13:40:16, Randy Smith (Not in Mondays) wrote:
> Matt: This is ready for a second review.  PTAL?

LGTM. Am a bit nervous that something could now be failing open, but I agree
this change makes sense, and am not going to spend an hour or two carefully
scrutinizing each individual test.

[Randy Smith (Not in Mondays), 2017-06-09 17:42:53]

The CQ bit was checked by rdsmith@chromium.org

[commit-bot: I haz the power, 2017-06-09 17:43:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 17:48:55]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1497030173491290,
"parent_rev": "f628aefdd7302fc33611b9fedc129a4e1fb19b1d", "commit_rev":
"e4815989660c3ef60e99b55d9b936246714e4719"}

[commit-bot: I haz the power, 2017-06-09 17:49:07]

Description was changed from

==========
Change all "google.com" references in net/cookies to "foo.com".

This avoids repeatedly tripping over presubmit check @
https://cs.chromium.org/chromium/src/PRESUBMIT.py?q=PRESUBMIT.py&sq=package:c...

BUG=None
R=mmenke@chromium.org
==========

to

==========
Change all "google.com" references in net/cookies to "foo.com".

This avoids repeatedly tripping over presubmit check @
https://cs.chromium.org/chromium/src/PRESUBMIT.py?q=PRESUBMIT.py&sq=package:c...

BUG=None
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2930893002
Cr-Commit-Position: refs/heads/master@{#478326}
Committed:
https://chromium.googlesource.com/chromium/src/+/e4815989660c3ef60e99b55d9b93...
==========

[commit-bot: I haz the power, 2017-06-09 17:49:08]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/e4815989660c3ef60e99b55d9b93...