Fix cookie test that's been broken for a couple of years.

Fix cookie test that's been broken for a couple of years.

Attempt was failing as expected because the domains didn't match, not because
the intended behavior was being tested.

BUG=None
R=droger@chromium.org

Review-Url: https://codereview.chromium.org/2929923002
Cr-Commit-Position: refs/heads/master@{#478261}
Committed: https://chromium.googlesource.com/chromium/src/+/76ab563d1dd6be5040980abe45de645409cfdab4

[Randy Smith (Not in Mondays), 2017-06-08 19:23:47]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 19:24:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Randy Smith (Not in Mondays), 2017-06-08 19:24:37]

droger: PTAL?  I'm specifically interested if I'm testing based on the right
TypeParam for the ios variation in behavior, but you can check the domain change
as well as long as you're there.

[commit-bot: I haz the power, 2017-06-08 21:00:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 21:00:37]

Dry run: This issue passed the CQ dry run.

[droger, 2017-06-09 12:28:36]

LGTM

This test looks partly similar to TestHostEndsWithDot, but I guess it doesn't
really hurts if some of the functionality is tested twice.

[Randy Smith (Not in Mondays), 2017-06-09 13:39:14]

On 2017/06/09 12:28:36, droger wrote:
> LGTM
> 
> This test looks partly similar to TestHostEndsWithDot, but I guess it doesn't
> really hurts if some of the functionality is tested twice.

Thanks!  Yeah, there's a large amount of cleanup I could do in the cookie space
if I let myself get drawn into it, but I don't want to get distracted too much
off servicification.  This CL is already two yaks down :-}.

[Randy Smith (Not in Mondays), 2017-06-09 13:39:19]

The CQ bit was checked by rdsmith@chromium.org

[commit-bot: I haz the power, 2017-06-09 13:39:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 13:43:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497015559709510, "parent_rev":
"5434be20a6cc4227e1944cca8a600e3fd5c42457", "commit_rev":
"76ab563d1dd6be5040980abe45de645409cfdab4"}

[commit-bot: I haz the power, 2017-06-09 13:43:43]

Description was changed from

==========
Fix cookie test that's been broken for a couple of years.

Attempt was failing as expected because the domains didn't match, not because
the intended behavior was being tested.

BUG=None
R=droger@chromium.org
==========

to

==========
Fix cookie test that's been broken for a couple of years.

Attempt was failing as expected because the domains didn't match, not because
the intended behavior was being tested.

BUG=None
R=droger@chromium.org

Review-Url: https://codereview.chromium.org/2929923002
Cr-Commit-Position: refs/heads/master@{#478261}
Committed:
https://chromium.googlesource.com/chromium/src/+/76ab563d1dd6be5040980abe45de...
==========

[commit-bot: I haz the power, 2017-06-09 13:43:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/76ab563d1dd6be5040980abe45de...