[geometry] replace m12 with m21 when transform DOMPoint from DOMMatrix.

[geometry] replace m12 with m21 when transform DOMPoint from DOMMatrix.

there is wrong calculate when transform DOMPoint from DOMMatrix.
we should replace m12 with m21. 
unfortunately all of m12 and m21 values were zero in layout tests.
so it could not detect problems.

BUG=730441
Review-Url: https://codereview.chromium.org/2930883002
Cr-Commit-Position: refs/heads/master@{#478185}
Committed: https://chromium.googlesource.com/chromium/src/+/f81049d5a4f02b598815c00baa0d135b79304588

[Hwanseung Lee, 2017-06-08 12:38:56]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 12:39:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-06-08 12:41:26]

Description was changed from

==========
[geometry] replace m12 with m21 when transform DOMPoint from DOMMatrix.

there is wrong calculate when transform DOMPoint from DOMMatrix.
m12 and m21 were zero in layout tests. so it did not detect problems.

BUG=730441
==========

to

==========
[geometry] replace m12 with m21 when transform DOMPoint from DOMMatrix.

there is wrong calculate when transform DOMPoint from DOMMatrix.
we should replace m12 with m21. m12 and m21 were zero in layout tests.
so it did not detect problems.

BUG=730441
==========

[Hwanseung Lee, 2017-06-08 12:41:26]

hs1217.lee@samsung.com changed reviewers:
+ dominicc@chromium.org, jinho.bang@samsung.com

[Hwanseung Lee, 2017-06-08 12:42:10]

@dominicc, zino
PTAL, thank you.

[commit-bot: I haz the power, 2017-06-08 14:14:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 14:14:36]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2017-06-09 00:53:42]

Description was changed from

==========
[geometry] replace m12 with m21 when transform DOMPoint from DOMMatrix.

there is wrong calculate when transform DOMPoint from DOMMatrix.
we should replace m12 with m21. m12 and m21 were zero in layout tests.
so it did not detect problems.

BUG=730441
==========

to

==========
[geometry] replace m12 with m21 when transform DOMPoint from DOMMatrix.

there is wrong calculate when transform DOMPoint from DOMMatrix.
we should replace m12 with m21. 
unfortunately all of m12 and m21 values were zero in layout tests.
so it did not detect problems.

BUG=730441
==========

[Hwanseung Lee, 2017-06-09 00:54:11]

Description was changed from

==========
[geometry] replace m12 with m21 when transform DOMPoint from DOMMatrix.

there is wrong calculate when transform DOMPoint from DOMMatrix.
we should replace m12 with m21. 
unfortunately all of m12 and m21 values were zero in layout tests.
so it did not detect problems.

BUG=730441
==========

to

==========
[geometry] replace m12 with m21 when transform DOMPoint from DOMMatrix.

there is wrong calculate when transform DOMPoint from DOMMatrix.
we should replace m12 with m21. 
unfortunately all of m12 and m21 values were zero in layout tests.
so it could not detect problems.

BUG=730441
==========

[zino, 2017-06-09 02:16:54]

On 2017/06/08 12:42:10, Hwanseung Lee wrote:
> @dominicc, zino
> PTAL, thank you.

This patch looks good to me.
But please update another test file as well:
"Thanks! If you could also add tests under external/wpt/css/geometry-1/ for this
difference, that would be A+. :-)" by simonp in crbug.

Thanks :)

[Hwanseung Lee, 2017-06-09 03:29:06]

On 2017/06/09 02:16:54, zino wrote:
> On 2017/06/08 12:42:10, Hwanseung Lee wrote:
> > @dominicc, zino
> > PTAL, thank you.
> 
> This patch looks good to me.
> But please update another test file as well:
> "Thanks! If you could also add tests under external/wpt/css/geometry-1/ for
this
> difference, that would be A+. :-)" by simonp in crbug.
> 
> Thanks :)

i will upload other tests for external/wpt/css/geometry-1/ indirectly.
as far as i know, external/wpt/css/geometry-1/ is synchronized 
from https://github.com/w3c/web-platform-tests periodically.
so i'm going to upload tests at https://github.com/w3c/web-platform-tests.

[zino, 2017-06-09 03:30:42]

On 2017/06/09 03:29:06, Hwanseung Lee wrote:
> On 2017/06/09 02:16:54, zino wrote:
> > On 2017/06/08 12:42:10, Hwanseung Lee wrote:
> > > @dominicc, zino
> > > PTAL, thank you.
> > 
> > This patch looks good to me.
> > But please update another test file as well:
> > "Thanks! If you could also add tests under external/wpt/css/geometry-1/ for
> this
> > difference, that would be A+. :-)" by simonp in crbug.
> > 
> > Thanks :)
> 
> i will upload other tests for external/wpt/css/geometry-1/ indirectly.
> as far as i know, external/wpt/css/geometry-1/ is synchronized 
> from https://github.com/w3c/web-platform-tests periodically.
> so i'm going to upload tests at https://github.com/w3c/web-platform-tests.

lgtm

[Hwanseung Lee, 2017-06-09 03:33:04]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2017-06-09 03:33:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 03:38:06]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496979184991050, "parent_rev":
"cc04b79cdd8f1ab0f4d96ce6985ed2b290572cc7", "commit_rev":
"f81049d5a4f02b598815c00baa0d135b79304588"}

[commit-bot: I haz the power, 2017-06-09 03:38:19]

Description was changed from

==========
[geometry] replace m12 with m21 when transform DOMPoint from DOMMatrix.

there is wrong calculate when transform DOMPoint from DOMMatrix.
we should replace m12 with m21. 
unfortunately all of m12 and m21 values were zero in layout tests.
so it could not detect problems.

BUG=730441
==========

to

==========
[geometry] replace m12 with m21 when transform DOMPoint from DOMMatrix.

there is wrong calculate when transform DOMPoint from DOMMatrix.
we should replace m12 with m21. 
unfortunately all of m12 and m21 values were zero in layout tests.
so it could not detect problems.

BUG=730441

Review-Url: https://codereview.chromium.org/2930883002
Cr-Commit-Position: refs/heads/master@{#478185}
Committed:
https://chromium.googlesource.com/chromium/src/+/f81049d5a4f02b598815c00baa0d...
==========

[commit-bot: I haz the power, 2017-06-09 03:38:21]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f81049d5a4f02b598815c00baa0d...