third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.cpp - Issue 2930883002: [geometry] replace m12 with m21 when transform DOMPoint from DOMMatrix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.cpp

Issue 2930883002: [geometry] replace m12 with m21 when transform DOMPoint from DOMMatrix. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.cpp

diff --git a/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.cpp b/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.cpp

index 4290ed2c5d4899bc4e360a8866451371cca14f57..b3657e9ff4c1fd39a176e092648cb933d22a578e 100644

--- a/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.cpp

+++ b/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.cpp

@@ -276,7 +276,7 @@ DOMMatrix* DOMMatrixReadOnly::inverse() {

DOMPoint* DOMMatrixReadOnly::transformPoint(const DOMPointInit& point) {

if (is2D() && point.z() == 0 && point.w() == 1) {

- double x = point.x() * m11() + point.y() * m12() + m41();

+ double x = point.x() * m11() + point.y() * m21() + m41();

double y = point.x() * m12() + point.y() * m22() + m42();

return DOMPoint::Create(x, y, 0, 1);

}