Issue 2930783002: [vr] Exit to 2D when encountering URLs with strong RTL characters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2930783002: [vr] Exit to 2D when encountering URLs with strong RTL characters (Closed)

Created:
3 years, 6 months ago by Ian Vollick

Modified:
3 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3112

Project:
chromium

Visibility:
Public.

More Reviews

Description

[vr] Exit to 2D when encountering URLs with strong RTL characters BUG=730619 Review-Url: https://codereview.chromium.org/2925053004 Cr-Original-Commit-Position: refs/heads/master@{#477747} Review-Url: https://codereview.chromium.org/2930783002 . Cr-Commit-Position: refs/branch-heads/3112@{#232} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/1b2fdca8a155a7a575cb43e35c330593a54f6d2c

Patch Set 1 #

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -0 lines)			Patch
M	chrome/browser/android/vr_shell/textures/url_bar_texture.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/android/vr_shell/ui_unsupported_mode.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/metrics/histograms/enums.xml	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Ian Vollick

3 years, 6 months ago (2017-06-07 20:47:05 UTC) #1

Description was changed from

==========
[vr] Exit to 2D when encountering URLs with strong RTL characters

BUG=730619

Review-Url: https://codereview.chromium.org/2925053004
Cr-Commit-Position: refs/heads/master@{#477747}
(cherry picked from commit 3307d08bfa9a42a4c924720a4c606fb417cd9bc0)
==========

to

==========
[vr] Exit to 2D when encountering URLs with strong RTL characters

BUG=730619

Review-Url: https://codereview.chromium.org/2925053004
Cr-Original-Commit-Position: refs/heads/master@{#477747}
Review-Url: https://codereview.chromium.org/2930783002 .
Cr-Commit-Position: refs/branch-heads/3112@{#232}
Cr-Branched-From:
b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
Committed:
https://chromium.googlesource.com/chromium/src/+/1b2fdca8a155a7a575cb43e35c33...
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages