Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2925053004: [vr] Exit to 2D when encountering URLs with strong RTL characters (Closed)

Created:
3 years, 6 months ago by Ian Vollick
Modified:
3 years, 6 months ago
Reviewers:
cjgrant
CC:
chromium-reviews, feature-vr-reviews_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[vr] Exit to 2D when encountering URLs with strong RTL characters BUG=730619 Review-Url: https://codereview.chromium.org/2925053004 Cr-Commit-Position: refs/heads/master@{#477747} Committed: https://chromium.googlesource.com/chromium/src/+/3307d08bfa9a42a4c924720a4c606fb417cd9bc0

Patch Set 1 #

Patch Set 2 : rebaes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/browser/android/vr_shell/textures/url_bar_texture.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_unsupported_mode.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
Ian Vollick
3 years, 6 months ago (2017-06-07 14:17:39 UTC) #5
cjgrant
lgtm
3 years, 6 months ago (2017-06-07 14:36:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925053004/20001
3 years, 6 months ago (2017-06-07 17:56:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925053004/20001
3 years, 6 months ago (2017-06-07 20:13:34 UTC) #18
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 20:20:46 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3307d08bfa9a42a4c924720a4c60...

Powered by Google App Engine
This is Rietveld 408576698