Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2930483003: DevTools: make EventListenersView a proper widget (Closed)

Created:
3 years, 6 months ago by luoe
Modified:
3 years, 6 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: make EventListenersView a proper widget BUG=726972 Review-Url: https://codereview.chromium.org/2930483003 Cr-Commit-Position: refs/heads/master@{#477831} Committed: https://chromium.googlesource.com/chromium/src/+/71395e75bf75e447baeb4cf7a784ebd7c536c795

Patch Set 1 #

Total comments: 3

Patch Set 2 : ac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -14 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js View 1 3 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
luoe
Please take a look https://codereview.chromium.org/2930483003/diff/1/third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css File third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css (left): https://codereview.chromium.org/2930483003/diff/1/third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css#oldcode71 third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css:71: .event-listeners-sidebar-pane .toolbar { We no ...
3 years, 6 months ago (2017-06-06 18:45:21 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/2930483003/diff/1/third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js File third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js (right): https://codereview.chromium.org/2930483003/diff/1/third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js#newcode17 third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js:17: super(true); The shadow dom you create does not ...
3 years, 6 months ago (2017-06-07 21:42:40 UTC) #3
luoe
Thanks! https://codereview.chromium.org/2930483003/diff/1/third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js File third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js (right): https://codereview.chromium.org/2930483003/diff/1/third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js#newcode17 third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js:17: super(true); On 2017/06/07 21:42:39, pfeldman wrote: > The ...
3 years, 6 months ago (2017-06-07 22:24:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2930483003/20001
3 years, 6 months ago (2017-06-07 22:25:04 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 00:36:25 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/71395e75bf75e447baeb4cf7a784...

Powered by Google App Engine
This is Rietveld 408576698