Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Unified Diff: third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js

Issue 2930483003: DevTools: make EventListenersView a proper widget (Closed)
Patch Set: ac Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js b/third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js
index 109bf64709b307db75e49eed610072792b26f694..e35dd9393441ecfd802316a85376e4464aca4df8 100644
--- a/third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js
+++ b/third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js
@@ -9,13 +9,12 @@ EventListeners.EventListenersResult;
/**
* @unrestricted
*/
-EventListeners.EventListenersView = class {
+EventListeners.EventListenersView = class extends UI.VBox {
/**
- * @param {!Element} element
* @param {function()} changeCallback
*/
- constructor(element, changeCallback) {
- this._element = element;
+ constructor(changeCallback) {
+ super();
this._changeCallback = changeCallback;
this._treeOutline = new UI.TreeOutlineInShadow();
this._treeOutline.hideOverflow();
@@ -23,7 +22,7 @@ EventListeners.EventListenersView = class {
this._treeOutline.registerRequiredCSS('event_listeners/eventListenersView.css');
this._treeOutline.setComparator(EventListeners.EventListenersTreeElement.comparator);
this._treeOutline.element.classList.add('monospace');
- this._element.appendChild(this._treeOutline.element);
+ this.element.appendChild(this._treeOutline.element);
this._emptyHolder = createElementWithClass('div', 'gray-info-message');
this._emptyHolder.textContent = Common.UIString('No event listeners');
this._linkifier = new Components.Linkifier();
@@ -191,7 +190,7 @@ EventListeners.EventListenersView = class {
allHidden = allHidden && eventType.hidden;
}
if (allHidden && !this._emptyHolder.parentNode)
- this._element.appendChild(this._emptyHolder);
+ this.element.appendChild(this._emptyHolder);
}
reset() {

Powered by Google App Engine
This is Rietveld 408576698